From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1939C433FE for ; Tue, 1 Feb 2022 03:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbiBADSi (ORCPT ); Mon, 31 Jan 2022 22:18:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbiBADSg (ORCPT ); Mon, 31 Jan 2022 22:18:36 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE4DDC06173B for ; Mon, 31 Jan 2022 19:18:36 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id i65so14615653pfc.9 for ; Mon, 31 Jan 2022 19:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=7ym4guToR5s6XJh+Gyaw0SuEv+LKx7FC/++SseskIfM=; b=E++ef+Q5iBCT3v/I5Xsw8Z42hgWOa0/CD59TDIXkDMY0W82NoIdVaA2wlQHAOqNgPW HVlfHK7n3vd7hCpdQvMsLK+QRFDHf+nMqZyVlPoR39FJ9/sq7mok7WbE7LsSq4UA96gB y4d/Dw5IEj6UGsD60pfH56R5yEmEtlkHe/oa+JG1q70MRkM214E+Q2ZVc2fM23xLE0Rt nhKk1G3dW79j8cHJpcnHjsPzWteJo7l2qH3qiSzZnoOBl9BjPaFQed0VBv+B3JHC4XOO dXEN0f2BkRCdaUQwNKxUlXgbqy2rWF2PXQUOdD42KKaisUfUC2EeMsCfLbv2tZHgtZuT 824A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=7ym4guToR5s6XJh+Gyaw0SuEv+LKx7FC/++SseskIfM=; b=218AHVLDWqS4jc6EINhOiOsIiR9UWhGjoPPDeXiiyUmH/73vChuJg15/LXIpuHnp8W H00hTXyziLu5BLUzcdvpWsWiLoTjFVbc47Jav4hQDcpq66zhhbs2guKYJbd1LAE5MihG 8UtqUP94S/T+i1kc79nFhexUDB/CARG2bch4FC+3J/1tV5hvg6rPmKFVwPTEa+9LqkDf sqLfpsKSorfPuVy0i4X/801zc1NK8CTTc119j7DA2SM+k41xyxiIwsq1pF7MRU17kzkX gRNqxE+cueezmt1xu8iTwz6b5Yl/LykSH1C0t4VnSc61VMvYlb/BJVI+vTxN/Go5gG5j Tr1g== X-Gm-Message-State: AOAM533JCsiw62Yz0G9148+8PZ1gWvB/HRioyqmp6CMt5U1s9azEYrP/ HnnyITEQluvQuctHB54qZhDoHg== X-Google-Smtp-Source: ABdhPJz49oSgsvYX6rVkuwCkpBFyCD/1vuYWgent4FpvFLEF81sRjkDpqWZmQXP+xsW7pCXULByM5A== X-Received: by 2002:a63:2c83:: with SMTP id s125mr15529210pgs.265.1643685516138; Mon, 31 Jan 2022 19:18:36 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id c8sm13261985pfv.57.2022.01.31.19.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 19:18:35 -0800 (PST) From: Kevin Hilman To: Saravana Kannan , Russell King , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Tony Lindgren , Catalin Marinas , Will Deacon , Damien Le Moal , Greg Kroah-Hartman , Saravana Kannan Cc: Ulf Hansson , Rob Herring , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/2] drivers: bus: simple-pm-bus: Add support for probing simple bus only devices In-Reply-To: <20210929000735.585237-2-saravanak@google.com> References: <20210929000735.585237-1-saravanak@google.com> <20210929000735.585237-2-saravanak@google.com> Date: Mon, 31 Jan 2022 19:18:35 -0800 Message-ID: <7hk0efmfzo.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, Saravana Kannan writes: > fw_devlink could end up creating device links for bus only devices. > However, bus only devices don't get probed and can block probe() or > sync_state() [1] call backs of other devices. To avoid this, probe these > devices using the simple-pm-bus driver. > > However, there are instances of devices that are not simple buses (they get > probed by their specific drivers) that also list the "simple-bus" (or other > bus only compatible strings) in their compatible property to automatically > populate their child devices. We still want these devices to get probed by > their specific drivers. So, we make sure this driver only probes devices > that are only buses. > > [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/ > Fixes: c442a0d18744 ("driver core: Set fw_devlink to "permissive" behavior by default") > Signed-off-by: Saravana Kannan > Tested-by: Saravana Kannan > Tested-by: Ulf Hansson This patch landed in stable/linux-5.10.y as commit d5f13bbb5104 and it broke suspend/resume on at least one TI AM335x board I'm testing on: upstream dts: arch/arm/boot/dts/am335x-icev2.dts, upstream defconfig: arch/arm/configs/omap2plus_defconfig. Bisecting between vanilla v5.10 (good) and stable/linux-5.10.y (bad) pointed me to this patch, and I confirmed that reverting just this patch on top of stable/linux-5.10.y makes it work again. Also interesting, this same platform works fine on vanilla v5.15, which also includes this patch. That suggests that either 1) this patch should not have been backported to v5.10 stable or 2) there are some other dependencies that are missing in v5.10. Since vanilla v5.10 works fine, I'm leaning towards (1), but if you have any ideas for deps that need backporting, I'm happy to try. I haven't debugged exactly where it's hanging yet, but, enabling CONFIG_DEBUG_DRIVER=y, and suspending with "no_console_suspend" on the command line, the last line before it hangs is: [ 28.129966] simple-pm-bus ocp: noirq power domain suspend Any ideas? Kevin