public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amlogic: meson-gx-socinfo: Update soc ids
Date: Wed, 07 Mar 2018 17:08:33 -0800	[thread overview]
Message-ID: <7ho9jzgyr2.fsf@baylibre.com> (raw)
In-Reply-To: <1518689694.2883.68.camel@baylibre.com> (Jerome Brunet's message of "Thu, 15 Feb 2018 11:14:54 +0100")

Jerome Brunet <jbrunet@baylibre.com> writes:

> On Wed, 2018-02-14 at 15:58 +0100, Neil Armstrong wrote:
>> Updates the Amlogic Meson SoCs IDs for the Armv8 based SoCs.
>> It includes the new families and packages.
>> 
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  drivers/soc/amlogic/meson-gx-socinfo.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index f2d8c3c..a7efe30 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -33,6 +33,10 @@ static const struct meson_gx_soc_id {
>>  	{ "GXL", 0x21 },
>>  	{ "GXM", 0x22 },
>>  	{ "TXL", 0x23 },
>> +	{ "TXLX", 0x24 },
>> +	{ "AXG", 0x25 },
>> +	{ "GXLX", 0x26 },
>> +	{ "TXHD", 0x27 },
>>  };
>>  
>>  static const struct meson_gx_package_id {
>> @@ -47,6 +51,10 @@ static const struct meson_gx_package_id {
>>  	{ "S905L", 0x21, 0xc0 },
>>  	{ "S905M2", 0x21, 0xe0 },
>>  	{ "S912", 0x22, 0 },
>> +	{ "962X", 0x24, 0x10 },
>> +	{ "962E", 0x24, 0x20 },
>> +	{ "A113X", 0x25, 0x37 },
>> +	{ "A113D", 0x25, 0xd0 },
>>  };
>>  
>>  static inline unsigned int socinfo_to_major(u32 socinfo)
>
> Tested on my s400 board which, according to the marking, features an AXG A113D.
> AXG is detected correctly but the package id read is 0x22 instead of 0xd0.

Neil, can you update accordingly?  Have you seen 0xd0 on other A11x
chips?  or is this from the docs?

Kevin

  reply	other threads:[~2018-03-08  1:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 14:58 [PATCH] amlogic: meson-gx-socinfo: Update soc ids Neil Armstrong
2018-02-15 10:14 ` Jerome Brunet
2018-03-08  1:08   ` Kevin Hilman [this message]
2018-03-08  9:36     ` Neil Armstrong
2018-03-08 19:45       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ho9jzgyr2.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox