From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932467AbdJ3Q4h (ORCPT ); Mon, 30 Oct 2017 12:56:37 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:43701 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbdJ3Q4g (ORCPT ); Mon, 30 Oct 2017 12:56:36 -0400 X-Google-Smtp-Source: ABhQp+SPwlh33PQlcmheslW4DIzwnNTvC1yx+xLGPb74//2MyQnDhXELrz3V64X8yvPu9avHhKo5ww== From: Kevin Hilman To: Ulf Hansson Cc: Neil Armstrong , Carlo Caione , linux-pm@lists.linux-foundation.org, "open list\:ARM\/Amlogic Meson..." , "linux-arm-kernel\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver Organization: BayLibre References: <1509208583-30349-1-git-send-email-narmstrong@baylibre.com> <1509208583-30349-2-git-send-email-narmstrong@baylibre.com> Date: Mon, 30 Oct 2017 17:56:33 +0100 In-Reply-To: (Ulf Hansson's message of "Mon, 30 Oct 2017 16:40:07 +0100") Message-ID: <7ho9ootvzy.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ulf Hansson writes: > Hi Neil, > > [...] > >> + >> + pm_genpd_init(&vpu_hdmi_pd.genpd, &simple_qos_governor, >> + meson_gx_pwrc_vpu_get_power(&vpu_hdmi_pd)); >> + > > This means that you may initialize the genpd in powered on state. > > For that scenario, I think you will hit a clock unprepare/disable > in-balance issue when genpd calls your ->power_off() callback, simply > because you didn't call clk_prepare_enable() for the clocks first. Yup, in my testing, I definitely hit this. Kevin