From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] clk: meson: axg: add Video Clocks
Date: Fri, 11 Sep 2020 10:10:31 -0700 [thread overview]
Message-ID: <7hr1r8xmrc.fsf@baylibre.com> (raw)
In-Reply-To: <6132edc1-0256-8eca-d5fd-8870aed5bb60@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 10/09/2020 12:13, Jerome Brunet wrote:
[...]
>> Why is NOCACHE ? Is there something poking behind CCF back ? if yes, why
>> is this required ?
>
> I'm surprised you ask this since the situation hasn't changed since I pushed the
> video clock for GXBB, then G12A.
Even if the situation hasn't changed, providing context is very helpful
for new reviewers or reviewers who might need a reminder of that
situation. I for one had already forgotten the video clock context so I
had a similiar question as Jerome when I saw the NOCACHE and UNUSED
flags.
As you know, new usage of those flags is always highly scrutinized, so
providing the right context and explanation, even if it's repeating
stuff you've stated elsewhere, can help preempt any questions.
> The switch to CCF for the VPU is still planned, but until now I was unable to allocate enough
> time for this huge rework.
>
> Since I'm the single DRM driver contributor and lacking any other reviewers, I must deal
> with new features & bugfixing before moving to CCF.
Not at all a blocker for this patch, but just curious do you have a TODO
list someplace for this driver in case others might have some time to
help you with the migration?
> The clock situation is far from perfect, and I'd also like it to be solved at some point.
>
> I'll add the same explanation I gave for GXBB in https://lkml.kernel.org/r/1541516257-16157-5-git-send-email-narmstrong@baylibre.com
Yes, that's perfect.
Thanks,
Kevin
next prev parent reply other threads:[~2020-09-11 17:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:38 [PATCH 0/4] clk: meson: axg: add clocks for MIPI-DSI support Neil Armstrong
2020-09-07 9:38 ` [PATCH 1/4] dt-bindings: clk: axg-clkc: add Video Clocks Neil Armstrong
2020-09-07 9:38 ` [PATCH 2/4] dt-bindings: clk: axg-clkc: add MIPI DSI Host clock binding Neil Armstrong
2020-09-07 9:38 ` [PATCH 3/4] clk: meson: axg: add Video Clocks Neil Armstrong
2020-09-10 10:13 ` Jerome Brunet
2020-09-10 11:47 ` Neil Armstrong
2020-09-11 17:10 ` Kevin Hilman [this message]
2020-09-07 9:38 ` [PATCH 4/4] clk: meson: axg: add MIPI DSI Host clock Neil Armstrong
2020-09-10 10:15 ` Jerome Brunet
2020-09-10 11:48 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hr1r8xmrc.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox