From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84AF8242D60 for ; Fri, 13 Mar 2026 00:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361046; cv=none; b=MxlKbvI5sFp2o+nCH/xbMa8AiDcx3wY5BGRK8bwQxt5TRHEf+FhtdiTdg2qVCo7DObJ2CvTKZ4+PIGSClJEiJGRIZcJev9wmNdF+80oa78wte+fa30XT/IisWelPSMr4g9MJcxN7tvJ6n7SNI2HSKQ74IW0Ob7NkIfcRqOkOpWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773361046; c=relaxed/simple; bh=sBDJiycTYdIuQYP8aXJgcHXx7wyBEVeAIRSLsbiJbcY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ozOVaxW99/l2zrs498zaTpawHYxZvOoWTer35q3mJKwzLejoqXNodNLfZFgzrg3xRBSXeJwa1iSQWR+9PxH2h8jv1D7sTtAZShU3hfGJkYU0c677eM3OdPFJsArWVOUwyDRvkMPCL9PxQmsrD+rRaZWJEVnJzrT7hR6eW036rEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Qax2nKfM; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Qax2nKfM" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-35a1cc6e478so607562a91.0 for ; Thu, 12 Mar 2026 17:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773361042; x=1773965842; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=cyKlpEvu/Gz33z23N2eapbn1Hxc35CxSf0FmojMpCCA=; b=Qax2nKfM72joEFK54+3nPClkCjw15Y7WXk2erpPlVNX88M4fxnweRjzES3T4QxpvBs krUX3CHV2+7tnRdHn4FfZeNB1GZoxo46340rFI1Qtje8iGc9kn02H5Z5I4l1nVdU3p0x cLQ2EYEjuSx+qGN/5OoYknNBbjpKfLRneiQ6cbQ5V7ILRkpX2VsYuF54+M0wMF/Sd6do /E4WBD7pkiaaa7QCAMR5B5JwU8aPqNOBfoqlEHpIlrB1FBRTPUqpeIOD78cEa4aMX1BV GJ51TE/pnw4as7/r0ZxsupgD5L4+PwQ0Ijf6pIdBVhFtXQxHOrhDSuSqcFg3tYCH5Zs6 vxGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773361042; x=1773965842; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cyKlpEvu/Gz33z23N2eapbn1Hxc35CxSf0FmojMpCCA=; b=WZFuc4FTGZOfR0hPbLmYU69Q22Z9ZO+XWkJOsRiM+vcbJRbGnmh9lYAaoW84KFcD4J +X3LMVGFjLqjvRUDcYWCXBBoBf5Gtq+ina0JYsyXe3YOYSQg8KwcmiP95WsZ799Ir0Pi T+ehUNgZRYL4hHy+HNfL2NiYlYDmgtKbFl3iIJfZ/jUpmpGrY1mexgqo1JYYLzJNsD6B VU8Ye6czKL0jbdHJH9l2SfjEF//L519i55Fyd/im+SqSOG4P+Ef9WQLnZyTgJSohmxZa o+skCr+yWWF3Z35JhT70MsxJ9WXX66UlzLmMyhlRoes+ngVNFk8R3Z4Exn5NqfeT57U8 6HzA== X-Forwarded-Encrypted: i=1; AJvYcCXfjubGxY36YluLeayLY5vFtDDxNrIKpkUhJbUZW9p09EvA1Ct0IiuNmJ5WVBGtgktJRQCfdIGPO/dsLzg=@vger.kernel.org X-Gm-Message-State: AOJu0YzFEGdKo8rJBt08gi2UvGQFod1vjzPFQXzHoTiXU8Q0WLzDLlzh 3bymGhCulKSSenYgqC7eJY8v4i229ODA69RuRw8xBkf/rxVYf8nHYXDG85NtBr1VTvA= X-Gm-Gg: ATEYQzwR2JLgjul/fPwix9xd5adAZyj2NOw9snrcXMiNTuQ3IfqRU11D1Rmt+SehUGO +c6TLxnNV5z5N+5Mms7BKeIN4R21lMcy/pnppsgcb6USqZI/Q5I2UkkgSgZbLxZoxxEH9Mmhaqw rDTTzv45Y3LK4jwXE/FDXHiC6tnlx9Fr8U6qkWGI3bgr/1UlqzF2Nrkeoitl6dRCLgAR3kZKd6g ELDsa6Mrt2PxWhHPXveksqVQo2azRF28hQobJuaDjmlAY+y7IgErx2DLYpTXuyC0qslm/F3Wo+e woG5+NpSW8kbXFAV9BgX2rYvPeGHgQMNOZi4YLR+10SylN7ddOlE8T8r+z7BjK6P2dZrguhXtYe XqwYf9gJEHe9uXgCVujWiawbyaFRUrmd1il8D9jMwPPDqEfb0UPw0Kiev3heDzGup4zGm5AEuzW PQF0VplMwpNmaqBy6UDzCdRaZUpCoY0Q== X-Received: by 2002:a17:90b:3b87:b0:32e:a8b7:e9c with SMTP id 98e67ed59e1d1-35a22082de9mr1145911a91.29.1773361042647; Thu, 12 Mar 2026 17:17:22 -0700 (PDT) Received: from localhost ([97.126.187.42]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a22cb532fsm312631a91.1.2026.03.12.17.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 17:17:22 -0700 (PDT) From: Kevin Hilman To: Andrew Goodbody , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Christopher Obbard , Andrew Goodbody Subject: Re: [PATCH] ARM: dts: omap: dm816x: Correct pinctrl register In-Reply-To: <20260312-dm816x_dt-v1-1-ed3370b20799@linaro.org> References: <20260312-dm816x_dt-v1-1-ed3370b20799@linaro.org> Date: Thu, 12 Mar 2026 17:17:21 -0700 Message-ID: <7htsuk1t2m.fsf@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Andrew Goodbody writes: > The delcaration in the pinmux device for the pinctrl registers is not minor nit: s/delcaration/declaration/, but no need to respin. I'll fix up when applying. > correct. These registers are actually 32 bits wide, not 16. Also the > mask for functional bits is also wrong. Functional bits are 0-4, not > 0-3. So the mask needs to changed to 0x1f. > > This information is taken from the TMS320DM816x DaVinci > Digital Media Processors Technical Reference Manual. > SPRUGX8C March 2015 > > Signed-off-by: Andrew Goodbody good catch! Thank you for the fix. Kevin > --- > arch/arm/boot/dts/ti/omap/dm816x.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi > index 407d7bc5b13a364548087dd5fb2659286bbd8537..a1e0e904e0f05cd725e71da70bffbde2dd2b2e38 100644 > --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi > +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi > @@ -94,8 +94,8 @@ dm816x_pinmux: pinmux@800 { > #address-cells = <1>; > #size-cells = <0>; > #pinctrl-cells = <1>; > - pinctrl-single,register-width = <16>; > - pinctrl-single,function-mask = <0xf>; > + pinctrl-single,register-width = <32>; > + pinctrl-single,function-mask = <0x1f>; > }; > > /* Device Configuration Registers */ > > --- > base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7 > change-id: 20260312-dm816x_dt-abe888f372e3 > > Best regards, > -- > Andrew Goodbody