From: Kevin Hilman <khilman@baylibre.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc: Amjad Ouled-Ameur <aouledameur@baylibre.com>,
p.zabel@pengutronix.de, balbi@kernel.org, jbrunet@baylibre.com,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 0/3] usb: meson: fix shared reset control use
Date: Fri, 19 Nov 2021 11:27:32 -0800 [thread overview]
Message-ID: <7htug854kb.fsf@baylibre.com> (raw)
In-Reply-To: <20211112162827.128319-1-aouledameur@baylibre.com>
Amjad Ouled-Ameur <aouledameur@baylibre.com> writes:
> This patchset fixes a usb suspend warning seen on the libretech-cc by
> using reset_control_rearm() call of the reset framework API.
> This call allows a reset consummer to release the reset line even when
> just triggered so that it may be triggered again by other reset
> consummers.
>
> reset_control_(de)assert() calls are called, in some meson usb drivers,
> on a shared reset line when reset_control_reset has been used. This is not
> allowed by the reset framework.
>
> Finally the meson usb drivers are updated to use this new call, which
> solves the suspend issue addressed by the previous reverted
> commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control
> use").
Tested-by: Kevin Hilman <khilman@baylibre.com>
Tested suspend/resume on Khadas VIM3 and confirmed that the reset
warnings are gone.
Kevin
prev parent reply other threads:[~2021-11-19 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 16:28 [PATCH v3 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur
2021-11-12 16:28 ` [PATCH v3 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use Amjad Ouled-Ameur
2021-11-20 23:39 ` Martin Blumenstingl
2021-11-22 9:03 ` Philipp Zabel
2021-12-05 21:13 ` Amjad Ouled-Ameur
2021-11-12 16:28 ` [PATCH v3 2/3] usb: dwc3: meson-g12a: fix shared reset control use Amjad Ouled-Ameur
2021-11-20 23:51 ` Martin Blumenstingl
2021-11-22 9:04 ` Anand Moon
2021-11-12 16:28 ` [PATCH v3 3/3] phy: amlogic: meson8b-usb2: " Amjad Ouled-Ameur
2021-11-20 23:57 ` Martin Blumenstingl
2021-12-05 21:35 ` Amjad Ouled-Ameur
2021-11-19 19:27 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7htug854kb.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=aouledameur@baylibre.com \
--cc=balbi@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox