From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FD0C432C2 for ; Wed, 25 Sep 2019 22:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A5BD21D81 for ; Wed, 25 Sep 2019 22:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="eoqlvEqQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730023AbfIYWzI (ORCPT ); Wed, 25 Sep 2019 18:55:08 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43044 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729638AbfIYWzH (ORCPT ); Wed, 25 Sep 2019 18:55:07 -0400 Received: by mail-pf1-f195.google.com with SMTP id a2so412868pfo.10 for ; Wed, 25 Sep 2019 15:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=9WC9auWepUy78cUJN0aqVvX0lDk3WeTONEi6+SRxepQ=; b=eoqlvEqQxVKWBUggvKjRbdxmqgttREvbLfuo9DiOOEnl2OUh0wUEp4SrUi0xIDRbOq V5BovfMxNoOTiYrIiSiauLlB8IUPau86O8w5VEXiD89gUa97Tl/hmc9Ekwgnhc3cmDDX RCVE98WWlxe5UCCRhwuKjewoproUEVcDDZn2Z7ovjumQvyzfAfFDXT0nM1ZkInMVe72B VkR1u6V510QP34t6MdbbFP0KMeIrp3VIPtM8KvFxMpohWWNV9dUR5mYxWZojPXbGw88e zSx8oPFkeq8P3EH3hQMKVB8CgNQS3nCZvaVsFjl/GjssU+6pbt/DNxOPMyLicl236ns9 g9kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=9WC9auWepUy78cUJN0aqVvX0lDk3WeTONEi6+SRxepQ=; b=Op/v3FyaEMKF5jAe7dG0VF9aYVsY8l+RqKt9tsVmsCxYtuVsPrx/2QVrJ/7W1YU4kD LJHUq6f5jTosO/EupceaOM1IJCIU5KmuVwwsopbhpZylrWDhJjU7J7PxSHobCgYMefKV ZBitamh8jczdn8otKxP4U8nAJBUrTMEoOe7jNROIpz19PQaaGjrgFdzSq7H3oqXu3P3p N1EkhiWcpJ5aRk1zA0LN6nlf0Y0rG8ld7v1ySxZQIT61x91NHKG0Oa2BC6BjYdvtiZAW Z98tANkBKQkU3huhc+Lq0qgLu5/3KvmYDwrM14ZAb652Xg8fBEOCCKL8eSHd1TDymKXE WGng== X-Gm-Message-State: APjAAAXQx7fgzQA85kwUS14LNs5tGLkW95AMq29UVFgTy/Z5SVA05Ouv rxGIvBjnvIogpgc5tdZen6TySQ== X-Google-Smtp-Source: APXvYqyHy++T2AILkhhlqZKUmq7GMsbUVh3oS83mlr5NVQ7OOev5eiPms6EaAI0vnUK3PPzAG6b4fg== X-Received: by 2002:a17:90a:244f:: with SMTP id h73mr59911pje.137.1569452106814; Wed, 25 Sep 2019 15:55:06 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id y15sm62024pfp.111.2019.09.25.15.55.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2019 15:55:05 -0700 (PDT) From: Kevin Hilman To: Xingyu Chen , Philipp Zabel , Neil Armstrong Cc: Xingyu Chen , Jianxin Pan , Rob Herring , Jerome Brunet , Hanjie Lin , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller In-Reply-To: <1569227661-4261-3-git-send-email-xingyu.chen@amlogic.com> References: <1569227661-4261-1-git-send-email-xingyu.chen@amlogic.com> <1569227661-4261-3-git-send-email-xingyu.chen@amlogic.com> Date: Wed, 25 Sep 2019 15:55:05 -0700 Message-ID: <7htv90rnp2.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xingyu Chen writes: > Add DT bindings for the Meson-A1 SoC Reset Controller include file, > and also slightly update documentation. > > Signed-off-by: Xingyu Chen > Signed-off-by: Jianxin Pan The order here doesn't look right. As the sender, your sign-off should be last. Is Jianxin the author or are you? If Jianxin, there should be a "From:" line at the beginning of the changelog to indicate authorship that's different from the sender. > --- > .../bindings/reset/amlogic,meson-reset.yaml | 1 + > include/dt-bindings/reset/amlogic,meson-a1-reset.h | 59 ++++++++++++++++++++++ > 2 files changed, 60 insertions(+) > create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > index 00917d8..b3f57d8 100644 > --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > @@ -16,6 +16,7 @@ properties: > - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs > - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs > - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs > + - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs > > reg: > maxItems: 1 > diff --git a/include/dt-bindings/reset/amlogic,meson-a1-reset.h b/include/dt-bindings/reset/amlogic,meson-a1-reset.h > new file mode 100644 > index 00000000..8d76a47 > --- /dev/null > +++ b/include/dt-bindings/reset/amlogic,meson-a1-reset.h > @@ -0,0 +1,59 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + * > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + * Author: Xingyu Chen > + * > + */ > + > +#ifndef _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H > +#define _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H > + > +/* RESET0 */ > +#define RESET_AM2AXI_VAD 1 minor nit: can you use comments/whitespace here to indicate holes? Please see the other amlogic files in this dir for examples. Kevin