From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD814C43603 for ; Tue, 10 Dec 2019 18:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4079206D5 for ; Tue, 10 Dec 2019 18:43:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="SfH4rbV9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbfLJSnI (ORCPT ); Tue, 10 Dec 2019 13:43:08 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45694 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727568AbfLJSnI (ORCPT ); Tue, 10 Dec 2019 13:43:08 -0500 Received: by mail-pf1-f195.google.com with SMTP id 2so250585pfg.12 for ; Tue, 10 Dec 2019 10:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=cXgeofGslOi+RjL/J6mEqJJEbNd8kJE15RHzG972FUQ=; b=SfH4rbV9YZ1hWUHfo6cMIDDXDMylmGSkT93R4GTh+Vcu9RUxPGbiNBkAG3NbdHpxLv G1SKn9dJ2jYhaRCFo3u55A1kll1ZmyWpn4zM876CL3bjaHxBuPO16j48vc4Eamz3b/k1 K2RPNZft07rIOQeGIXjppjTzrLmt28J4ZXLxwcsdCt1AxZ4CGFaTm/Y/wbPnPG71pkIw GRKkwd5rks5xS9URrQMyPKsIEowX25fbB4RuXFxGhqmoGv39UtNs0dWn79kCP+ec1XLo hNxzRCHUIR3xk7YRLPXCX9yEIBs86nu0PTIHkJ84zHzuJ4p4qhBV+Ga6CCnNwEp974ba klHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=cXgeofGslOi+RjL/J6mEqJJEbNd8kJE15RHzG972FUQ=; b=MxHfqRjWxXC6c2cD70CgLF0KwgFR+p82Y0mVS/4nhHHV3Y031nFrXHTIooZ3Qr8JGk Gbc2XoNXkFRFfUzLpWx/dD3XrIoTi+/8UEYC/vhekwLu3ykOL8D6u8szNuKD3IWR5Zf1 m/1SWPaFgBarCYTwYgEs7wNXL9UjRkoxiQKYzEsPTEkeo6iF3LmpoRNQo3qWW8t8cW8U gFyMxrT/31+YSBAUYowULpafiLgfY7d8bU/f15Dk3OktvbLfUy2MN9J+yH9AvG+YhJ4a SQCGiWBGJfjzU3F6aWG9r7pVdDM41FQmbYg4OjpU7f4O4j8p+5sRPc0G+lOFZ6I71Gu5 VXkg== X-Gm-Message-State: APjAAAVDCHuJ+TVStAcNbmlA4n1beQw5kJ6arbwvOSaZdoIZywAUThxu 92i4qi33+VPcUrZZRbUh+/foyg== X-Google-Smtp-Source: APXvYqxAch1OM+Hj+dyhmaGulL00rkkcafPXofsHFHUk6+pyjE/E1S2dK7Z5HJ8gaKs6VYJkuFVJkA== X-Received: by 2002:aa7:8d4d:: with SMTP id s13mr14405829pfe.18.1576003387448; Tue, 10 Dec 2019 10:43:07 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id k15sm4313480pfg.37.2019.12.10.10.43.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Dec 2019 10:43:06 -0800 (PST) From: Kevin Hilman To: Jerome Brunet , Jian Hu , Neil Armstrong Cc: "Rob Herring" , Martin Blumenstingl , Michael Turquette , Wolfram Sang , Mark Rutland , Jianxin Pan , linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: meson-a1: add I2C nodes In-Reply-To: <1j8snkh4cz.fsf@starbuckisacylon.baylibre.com> References: <20191202111253.94872-1-jian.hu@amlogic.com> <1j8snkh4cz.fsf@starbuckisacylon.baylibre.com> Date: Tue, 10 Dec 2019 10:43:06 -0800 Message-ID: <7hwob4owcl.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > On Mon 02 Dec 2019 at 12:12, Jian Hu wrote: > >> There are four I2C controllers in A1 series, >> Share the same comptible with AXG.The I2C nodes >> depend on pinmux and clock controller. >> >> Signed-off-by: Jian Hu >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 149 ++++++++++++++++++++++ >> 1 file changed, 149 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> index eab2ecd36aa8..d0a73d953f5e 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> @@ -16,6 +16,13 @@ >> #address-cells = <2>; >> #size-cells = <2>; >> >> + aliases { >> + i2c0 = &i2c0; >> + i2c1 = &i2c1; >> + i2c2 = &i2c2; >> + i2c3 = &i2c3; >> + }; >> + > > I wonder if assigning i2c bus alias in the SoC dtsi is such a good idea. > > Such aliases are usually assigned as needed by each board design: > meson-a1-ad401.dts in your case. Agreed. I don't think SoC-wide aliases are a great idea. Kevin