From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbbKRRrA (ORCPT ); Wed, 18 Nov 2015 12:47:00 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36334 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbbKRRq6 (ORCPT ); Wed, 18 Nov 2015 12:46:58 -0500 From: Kevin Hilman To: Jun Nie Cc: Arnd Bergmann , arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: zx: only build power domain code when CONFIG_PM=y References: <5298444.vriZVZrvnf@wuerfel> Date: Wed, 18 Nov 2015 09:46:55 -0800 In-Reply-To: (Jun Nie's message of "Tue, 17 Nov 2015 09:20:17 +0800") Message-ID: <7hwptfyzcg.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jun, Jun Nie writes: > 2015-11-17 1:01 GMT+08:00 Arnd Bergmann : > >> The newly added zx power domain code causes build errors in >> some configurations: >> >> warning: (PM_RMOBILE && SOC_ZX296702) selects PM_GENERIC_DOMAINS which has >> unmet direct dependencies (PM) >> warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct >> dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) >> power/domain.c: In function 'genpd_queue_power_off_work': >> power/domain.c:192:13: error: 'pm_wq' undeclared (first use in this >> function) >> queue_work(pm_wq, &genpd->power_off_work); >> ^ >> power/domain.c:192:13: note: each undeclared identifier is reported only >> once for each function it appears in >> >> This ensures we don't try to enable it when CONFIG_PM is >> disabled, mirroring what we do on most other platforms. >> >> Signed-off-by: Arnd Bergmann >> Fixes: f15107f41282 ("ARM: zx: Add power domains for ZX296702") >> >> diff --git a/arch/arm/mach-zx/Kconfig b/arch/arm/mach-zx/Kconfig >> index 7fdc5bf24f9b..446334a25cf5 100644 >> --- a/arch/arm/mach-zx/Kconfig >> +++ b/arch/arm/mach-zx/Kconfig >> @@ -13,7 +13,7 @@ config SOC_ZX296702 >> select ARM_GLOBAL_TIMER >> select HAVE_ARM_SCU if SMP >> select HAVE_ARM_TWD if SMP >> - select PM_GENERIC_DOMAINS >> + select PM_GENERIC_DOMAINS if PM >> help >> Support for ZTE ZX296702 SoC which is a dual core CortexA9MP >> endif >> >> Reviewed-by: Jun Nie FYI.. Not sure what mailer you're using, but your "reviewd-by" tag (as well as the first line of some of your other replies) are showing up in the quoted section of the previous mail, so it's not obvious at first glance which part is your reply, and which part you're replying to. Kevin