From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbbJMVVk (ORCPT ); Tue, 13 Oct 2015 17:21:40 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35052 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798AbbJMVVi (ORCPT ); Tue, 13 Oct 2015 17:21:38 -0400 From: Kevin Hilman To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Ray Jui , Hauke Mehrtens , Tyler Baker , lkml , Olof Johansson , Mark Brown , bcm-kernel-feedback-list@broadcom.com, Linux PCI , Bjorn Helgaas Subject: Re: [PATCH] PCI: iproc: fix 32-bit build error References: <1442363962-29805-1-git-send-email-rjui@broadcom.com> <1442363962-29805-8-git-send-email-rjui@broadcom.com> <11199595.GgDE2yo8AA@wuerfel> Date: Tue, 13 Oct 2015 14:21:35 -0700 In-Reply-To: <11199595.GgDE2yo8AA@wuerfel> (Arnd Bergmann's message of "Tue, 13 Oct 2015 22:02:48 +0200") Message-ID: <7hwpuqcvmo.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The iproc PCI driver tries to figure out whether the MMIO window has > a valid size, but does this using a 64-bit modulo operation, which > is not allowed on 32-bit kernels and leads to a link error: > > drivers/built-in.o: In function `iproc_pcie_setup': > :(.text+0x4b798): undefined reference to `__aeabi_uldivmod' > > This works around that error by using the div64_u64() function > provided by the kernel. While this is an expensive operation, > it is harmless because we only call it during the probing > of the driver. > > Signed-off-by: Arnd Bergmann > Fixes: 0ab99ca8eb6c ("PCI: iproc: Fix compile warnings") Tested-by: Kevin Hilman Verified that this fixes the build failure on arm multi_v7_defconfig + CONFIG_ARM_LPAE=y on top of next-20151013. Kevin