From: Kevin Hilman <khilman@linaro.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux@arm.linux.org.uk,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Will Deacon <will.deacon@arm.com>,
Chao Xie <chao.xie@marvell.com>,
Stephen Warren <swarren@nvidia.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Jonathan Austin <Jonathan.Austin@arm.com>,
Chao Xie Linux <xiechao.mail@gmail.com>,
Juri Lelli <juri.lelli@gmail.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number
Date: Fri, 15 Aug 2014 09:32:16 -0700 [thread overview]
Message-ID: <7hwqa9ww6n.fsf@paris.lan> (raw)
In-Reply-To: <1408004865-27525-1-git-send-email-juri.lelli@arm.com> (Juri Lelli's message of "Thu, 14 Aug 2014 09:27:45 +0100")
Juri Lelli <juri.lelli@arm.com> writes:
> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number
> correctly") changed ARM_CPU_PART_X masks, and the way they are returned and
> checked against. Usage of read_cpuid_part_number() is now deprecated, and
> calling places updated accordingly. This actually broke cpuidle-big_little
> initialization, as bl_idle_driver_init() performs a check using an hardcoded
> mask on cpu_id.
>
> Create an interface to perform the check (that is now even easier to read).
> Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks
> cleaner and helps preventing bugs in the future. Update usage accordingly.
[...]
Tested-by: Kevin Hilman <khilman@linaro.org>
FWIW, I can confirm that this patch is needed for cpuidle-big_little to
work on the Exynos5800/Chromebook2.
Kevin
next prev parent reply other threads:[~2014-08-15 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 8:27 [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number Juri Lelli
2014-08-15 10:07 ` Lorenzo Pieralisi
2014-08-15 16:32 ` Kevin Hilman [this message]
2014-08-15 16:36 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hwqa9ww6n.fsf@paris.lan \
--to=khilman@linaro.org \
--cc=Jonathan.Austin@arm.com \
--cc=chao.xie@marvell.com \
--cc=daniel.lezcano@linaro.org \
--cc=juri.lelli@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@calxeda.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=swarren@nvidia.com \
--cc=will.deacon@arm.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox