From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbcFAQaU (ORCPT ); Wed, 1 Jun 2016 12:30:20 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34498 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbcFAQaT (ORCPT ); Wed, 1 Jun 2016 12:30:19 -0400 From: Kevin Hilman To: Sudeep Holla , heiko@sntech.de Cc: Neil Armstrong , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 0/2] scpi: Add SCPI framework to handle vendors variants Organization: BayLibre References: <1464255491-18503-1-git-send-email-narmstrong@baylibre.com> <57472450.4000709@arm.com> <574802AF.2080909@baylibre.com> <574BFA13.40009@baylibre.com> <574EB4A5.9000805@arm.com> Date: Wed, 01 Jun 2016 09:30:16 -0700 In-Reply-To: <574EB4A5.9000805@arm.com> (Sudeep Holla's message of "Wed, 1 Jun 2016 11:10:45 +0100") Message-ID: <7hy46oeusn.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ + Heiko, who may know about the Rockchip implementation ] Sudeep Holla writes: > On 30/05/16 09:30, Neil Armstrong wrote: >> On 05/27/2016 10:17 AM, Neil Armstrong wrote: > > [..] > >> >> While looking for other ARMv8 based platform, I found that the RK3368 >> platform has the same SCPI implementation as Amlogic. >> >> They extended it with DDR, system and thermal commands. >> >> Look at : >> https://github.com/geekboxzone/mmallow_kernel/blob/geekbox/drivers/mailbox/scpi_cmd.h >> >>https://github.com/geekboxzone/mmallow_kernel/blob/geekbox/drivers/mailbox/scpi_protocol.c >> > > >> So the SCPI must have a framework to allow different protocol >> versions, and must allow command extension. Grouping Rockchip and >> Amlogic should be done, thus needing a generic name like vendor_scpi >> or with a version. >> > > Makes sense. I understand the need to reuse and I need a bit of time to > have a look at the code(both Amlogic one's you have pointed out and the > Rockchip one) in detail to see what's the best way to proceed. I will > have a look at this later this week and get back to you. > >> Sudeep, could you somehow find out which version of the protocol >> AmLogic and Rockchip based their SCPI development ? >> > > Yes I tried checking with Rockchip but didn't get a response. But my > guess is that it was some preliminary unpublished version of SCPI > unfortunately :( And if one partner did that, probably everyone else did as well, but this being the ARM universe, they all did it slightly differently. :( We know from experience, that this happens all the time in the absence of a clear standard, so this framework will need to be extended to be useful. Thanks, Kevin