Re: [PATCH v9 1/8] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC

Andreas Kemnade
2026-03-03T21:02:45Z

On Tue, 3 Mar 2026 15:30:10 -0500
Mithil Bavishi <bavishimithil@gmail.com> wrote:

> Add a dedicated DTS file for the TWL6032 PMIC (Phoenix Lite). Already
> has driver support with TWL6030 (Phoenix) since both of them are so
> similar, some nodes can be reused from TWL6030 as well
>
> This can be included in the board files like twl6030
> Example:
> ...
> &i2c1 {
> twl: twl@48 {
> reg = <0x48>;
> interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-controller;
> interrupt-parent = <&gic>;
> };
> };
>
> /include/ "twl6032.dtsi"
> ...
>
> Used in devices like samsung-espresso, amazon-jem, epson-embt2ws etc
>
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>

The best answer no that design antipattern in the twl driver
implementation. So

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>