From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbeAQAXR (ORCPT + 1 other); Tue, 16 Jan 2018 19:23:17 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:42647 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAQAXP (ORCPT ); Tue, 16 Jan 2018 19:23:15 -0500 X-Google-Smtp-Source: ACJfBotjLDH8gSMQhFd6aaaHcthxXm1OvytT/cq3qMtv9EcOe8nzinUFSjPcfgRtSkdkmlGyA/18CQ== From: Kevin Hilman To: Jerome Brunet Cc: Linus Walleij , Carlo Caione , linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin Organization: BayLibre References: <20180116162954.4945-1-jbrunet@baylibre.com> Date: Tue, 16 Jan 2018 16:23:02 -0800 In-Reply-To: <20180116162954.4945-1-jbrunet@baylibre.com> (Jerome Brunet's message of "Tue, 16 Jan 2018 17:29:54 +0100") Message-ID: <7hzi5dbaft.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Jerome Brunet writes: > GPIO bank mistakenly stops at GPIOAO_9 while it should stop at GPIOAO_13. > This gives -EINVAL if one tries to set/get anything on GPIOAO_10 to > GPIOAO_13 (pull, direction, value) > > Correcting the bank last pin fixes this problem > > Fixes: e072b0f1b03a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC") > Signed-off-by: Jerome Brunet Acked-by: Kevin Hilman > --- > > Hi Linus, > > This changes fixes code which was added during this cycle, so it intended > for your "for-next" branch, not the "fixes" one. > > Thanks > Jerome > > drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c > index a1a7d42afd42..6431d77a4704 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c > @@ -897,8 +897,8 @@ static struct meson_bank meson_axg_periphs_banks[] = { > }; > > static struct meson_bank meson_axg_aobus_banks[] = { > - /* name first last irq pullen pull dir out in */ > - BANK("AO", GPIOAO_0, GPIOAO_9, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), > + /* name first last irq pullen pull dir out in */ > + BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), > }; > > static struct meson_pmx_bank meson_axg_periphs_pmx_banks[] = {