From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753886AbcENRp5 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 14 May 2016 13:45:57 -0400
Received: from mail-pa0-f41.google.com ([209.85.220.41]:34479 "EHLO
	mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753385AbcENRp4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 14 May 2016 13:45:56 -0400
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller
Organization: BayLibre
References: <1463148012-25988-1-git-send-email-narmstrong@baylibre.com>
	<1463148012-25988-2-git-send-email-narmstrong@baylibre.com>
Date: Sat, 14 May 2016 10:45:54 -0700
In-Reply-To: <1463148012-25988-2-git-send-email-narmstrong@baylibre.com> (Neil
	Armstrong's message of "Fri, 13 May 2016 16:00:10 +0200")
Message-ID: <7hzirsh6st.fsf@baylibre.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> Controller.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

[...]

> +struct meson_gxbb_reset {
> +	void *reg_base;

nit: along wit the readw/writel, this should be void __iomem *.

> +	struct reset_controller_dev rcdev;
> +};

Kevin