From: Kevin Hilman <khilman@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PM / Domains: Make genpd parameter of pm_genpd_present() const
Date: Wed, 29 Oct 2014 10:06:47 -0700 [thread overview]
Message-ID: <7hzjceajq0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1414066336-11168-1-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Thu, 23 Oct 2014 14:12:15 +0200")
Geert Uytterhoeven <geert+renesas@glider.be> writes:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Kevin Hilman <khilman@linaro.org>
Though I tend to prefer a brief changlog that answers "why", even if it may seem obvious.
Kevin
> ---
> drivers/base/power/domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 40bc2f4072cc28ea..28d6e8bf746c4683 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -753,9 +753,9 @@ static inline void genpd_power_off_work_fn(struct work_struct *work) {}
> * pm_genpd_present - Check if the given PM domain has been initialized.
> * @genpd: PM domain to check.
> */
> -static bool pm_genpd_present(struct generic_pm_domain *genpd)
> +static bool pm_genpd_present(const struct generic_pm_domain *genpd)
> {
> - struct generic_pm_domain *gpd;
> + const struct generic_pm_domain *gpd;
>
> if (IS_ERR_OR_NULL(genpd))
> return false;
prev parent reply other threads:[~2014-10-29 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 12:12 [PATCH 1/2] PM / Domains: Make genpd parameter of pm_genpd_present() const Geert Uytterhoeven
2014-10-23 12:12 ` [PATCH 2/2] PM / Domains: Extract code to power off/on a PM domain Geert Uytterhoeven
2014-10-29 13:25 ` Ulf Hansson
2014-10-29 13:32 ` Geert Uytterhoeven
2014-10-29 13:37 ` Ulf Hansson
2014-10-29 17:09 ` Kevin Hilman
2014-10-29 17:06 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzjceajq0.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=geert+renesas@glider.be \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox