[PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[Bartosz Golaszewski]

Never got any further feedback on this series last cycle. Resending for
v6.17.

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. We're in the process of
converting all GPIO drivers to using the new API. This series converts
all the GPIO controllers under drivers/input/.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
      Input: ad7879 - use new GPIO line value setter callbacks
      Input: adp5588 - use new GPIO line value setter callbacks
      Input: adp5589 - use new GPIO line value setter callbacks

 drivers/input/keyboard/adp5588-keys.c |  9 +++++----
 drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
 drivers/input/touchscreen/ad7879.c    | 11 +++++++----
 3 files changed, 18 insertions(+), 13 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250331-gpiochip-set-rv-input-bc12818c5732

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

[PATCH RESEND 1/3] Input: ad7879 - use new GPIO line value setter callbacks

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/input/touchscreen/ad7879.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
index f9db5cefb25bca45e18e80fafc9cad5dd78f4f68..d2a3a5e016b6a5416846e8a9edf906c891d4038a 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -444,10 +444,11 @@ static int ad7879_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
 	return !!(val & AD7879_GPIO_DATA);
 }
 
-static void ad7879_gpio_set_value(struct gpio_chip *chip,
-				  unsigned gpio, int value)
+static int ad7879_gpio_set_value(struct gpio_chip *chip, unsigned int gpio,
+				 int value)
 {
 	struct ad7879 *ts = gpiochip_get_data(chip);
+	int ret;
 
 	mutex_lock(&ts->mutex);
 	if (value)
@@ -455,8 +456,10 @@ static void ad7879_gpio_set_value(struct gpio_chip *chip,
 	else
 		ts->cmd_crtl2 &= ~AD7879_GPIO_DATA;
 
-	ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2);
+	ret = ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2);
 	mutex_unlock(&ts->mutex);
+
+	return ret;
 }
 
 static int ad7879_gpio_add(struct ad7879 *ts)
@@ -472,7 +475,7 @@ static int ad7879_gpio_add(struct ad7879 *ts)
 	ts->gc.direction_input = ad7879_gpio_direction_input;
 	ts->gc.direction_output = ad7879_gpio_direction_output;
 	ts->gc.get = ad7879_gpio_get_value;
-	ts->gc.set = ad7879_gpio_set_value;
+	ts->gc.set_rv = ad7879_gpio_set_value;
 	ts->gc.can_sleep = 1;
 	ts->gc.base = -1;
 	ts->gc.ngpio = 1;

-- 
2.48.1

[PATCH RESEND 2/3] Input: adp5588 - use new GPIO line value setter callbacks

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/input/keyboard/adp5588-keys.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index dc734974ce0687a6e850242b531979be8395b394..2b2aca08423a4ee658db56f77bae25ef5a18e7a6 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -232,8 +232,8 @@ static int adp5588_gpio_get_value(struct gpio_chip *chip, unsigned int off)
 	return !!(val & bit);
 }
 
-static void adp5588_gpio_set_value(struct gpio_chip *chip,
-				   unsigned int off, int val)
+static int adp5588_gpio_set_value(struct gpio_chip *chip, unsigned int off,
+				  int val)
 {
 	struct adp5588_kpad *kpad = gpiochip_get_data(chip);
 	unsigned int bank = ADP5588_BANK(kpad->gpiomap[off]);
@@ -246,7 +246,8 @@ static void adp5588_gpio_set_value(struct gpio_chip *chip,
 	else
 		kpad->dat_out[bank] &= ~bit;
 
-	adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank, kpad->dat_out[bank]);
+	return adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank,
+			     kpad->dat_out[bank]);
 }
 
 static int adp5588_gpio_set_config(struct gpio_chip *chip,  unsigned int off,
@@ -424,7 +425,7 @@ static int adp5588_gpio_add(struct adp5588_kpad *kpad)
 	kpad->gc.direction_input = adp5588_gpio_direction_input;
 	kpad->gc.direction_output = adp5588_gpio_direction_output;
 	kpad->gc.get = adp5588_gpio_get_value;
-	kpad->gc.set = adp5588_gpio_set_value;
+	kpad->gc.set_rv = adp5588_gpio_set_value;
 	kpad->gc.set_config = adp5588_gpio_set_config;
 	kpad->gc.can_sleep = 1;
 

-- 
2.48.1

[PATCH RESEND 3/3] Input: adp5589 - use new GPIO line value setter callbacks

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index 81d0876ee358ef4b521f3f936dc2ab108bb4cda3..986a789f1ec3b3599dc94e1f6cd871e1df5e1537 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -404,8 +404,8 @@ static int adp5589_gpio_get_value(struct gpio_chip *chip, unsigned off)
 	return !!(val & bit);
 }
 
-static void adp5589_gpio_set_value(struct gpio_chip *chip,
-				   unsigned off, int val)
+static int adp5589_gpio_set_value(struct gpio_chip *chip, unsigned int off,
+				  int val)
 {
 	struct adp5589_kpad *kpad = gpiochip_get_data(chip);
 	unsigned int bank = kpad->var->bank(kpad->gpiomap[off]);
@@ -418,8 +418,9 @@ static void adp5589_gpio_set_value(struct gpio_chip *chip,
 	else
 		kpad->dat_out[bank] &= ~bit;
 
-	adp5589_write(kpad->client, kpad->var->reg(ADP5589_GPO_DATA_OUT_A) +
-		      bank, kpad->dat_out[bank]);
+	return adp5589_write(kpad->client,
+			     kpad->var->reg(ADP5589_GPO_DATA_OUT_A) + bank,
+			     kpad->dat_out[bank]);
 }
 
 static int adp5589_gpio_direction_input(struct gpio_chip *chip, unsigned off)
@@ -520,7 +521,7 @@ static int adp5589_gpio_add(struct adp5589_kpad *kpad)
 	kpad->gc.direction_input = adp5589_gpio_direction_input;
 	kpad->gc.direction_output = adp5589_gpio_direction_output;
 	kpad->gc.get = adp5589_gpio_get_value;
-	kpad->gc.set = adp5589_gpio_set_value;
+	kpad->gc.set_rv = adp5589_gpio_set_value;
 	kpad->gc.can_sleep = 1;
 
 	kpad->gc.base = gpio_data->gpio_start;

-- 
2.48.1

RE: [PATCH RESEND 1/3] Input: ad7879 - use new GPIO line value setter callbacks

[Hennerich, Michael]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@bgdev.pl>
> Sent: Tuesday, June 10, 2025 11:40 AM
> To: Hennerich, Michael <Michael.Hennerich@analog.com>; Dmitry Torokhov
> <dmitry.torokhov@gmail.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> gpio@vger.kernel.org; Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Subject: [PATCH RESEND 1/3] Input: ad7879 - use new GPIO line value setter
> callbacks
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return an integer,
> allowing to indicate failures. Convert the driver to using them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/touchscreen/ad7879.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ad7879.c
> b/drivers/input/touchscreen/ad7879.c
> index
> f9db5cefb25bca45e18e80fafc9cad5dd78f4f68..d2a3a5e016b6a5416846e8
> a9edf906c891d4038a 100644
> --- a/drivers/input/touchscreen/ad7879.c
> +++ b/drivers/input/touchscreen/ad7879.c
> @@ -444,10 +444,11 @@ static int ad7879_gpio_get_value(struct gpio_chip
> *chip, unsigned gpio)
>  	return !!(val & AD7879_GPIO_DATA);
>  }
> 
> -static void ad7879_gpio_set_value(struct gpio_chip *chip,
> -				  unsigned gpio, int value)
> +static int ad7879_gpio_set_value(struct gpio_chip *chip, unsigned int gpio,
> +				 int value)
>  {
>  	struct ad7879 *ts = gpiochip_get_data(chip);
> +	int ret;
> 
>  	mutex_lock(&ts->mutex);
>  	if (value)
> @@ -455,8 +456,10 @@ static void ad7879_gpio_set_value(struct gpio_chip
> *chip,
>  	else
>  		ts->cmd_crtl2 &= ~AD7879_GPIO_DATA;
> 
> -	ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2);
> +	ret = ad7879_write(ts, AD7879_REG_CTRL2, ts->cmd_crtl2);
>  	mutex_unlock(&ts->mutex);
> +
> +	return ret;
>  }
> 
>  static int ad7879_gpio_add(struct ad7879 *ts) @@ -472,7 +475,7 @@ static
> int ad7879_gpio_add(struct ad7879 *ts)
>  	ts->gc.direction_input = ad7879_gpio_direction_input;
>  	ts->gc.direction_output = ad7879_gpio_direction_output;
>  	ts->gc.get = ad7879_gpio_get_value;
> -	ts->gc.set = ad7879_gpio_set_value;
> +	ts->gc.set_rv = ad7879_gpio_set_value;
>  	ts->gc.can_sleep = 1;
>  	ts->gc.base = -1;
>  	ts->gc.ngpio = 1;
> 
> --
> 2.48.1

RE: [PATCH RESEND 3/3] Input: adp5589 - use new GPIO line value setter callbacks

[Hennerich, Michael]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@bgdev.pl>
> Sent: Tuesday, June 10, 2025 11:40 AM
> To: Hennerich, Michael <Michael.Hennerich@analog.com>; Dmitry Torokhov
> <dmitry.torokhov@gmail.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> gpio@vger.kernel.org; Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Subject: [PATCH RESEND 3/3] Input: adp5589 - use new GPIO line value setter
> callbacks
> 
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return an integer,
> allowing to indicate failures. Convert the driver to using them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> index
> 81d0876ee358ef4b521f3f936dc2ab108bb4cda3..986a789f1ec3b3599dc94
> e1f6cd871e1df5e1537 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -404,8 +404,8 @@ static int adp5589_gpio_get_value(struct gpio_chip
> *chip, unsigned off)
>  	return !!(val & bit);
>  }
> 
> -static void adp5589_gpio_set_value(struct gpio_chip *chip,
> -				   unsigned off, int val)
> +static int adp5589_gpio_set_value(struct gpio_chip *chip, unsigned int off,
> +				  int val)
>  {
>  	struct adp5589_kpad *kpad = gpiochip_get_data(chip);
>  	unsigned int bank = kpad->var->bank(kpad->gpiomap[off]);
> @@ -418,8 +418,9 @@ static void adp5589_gpio_set_value(struct gpio_chip
> *chip,
>  	else
>  		kpad->dat_out[bank] &= ~bit;
> 
> -	adp5589_write(kpad->client, kpad->var-
> >reg(ADP5589_GPO_DATA_OUT_A) +
> -		      bank, kpad->dat_out[bank]);
> +	return adp5589_write(kpad->client,
> +			     kpad->var->reg(ADP5589_GPO_DATA_OUT_A) +
> bank,
> +			     kpad->dat_out[bank]);
>  }
> 
>  static int adp5589_gpio_direction_input(struct gpio_chip *chip, unsigned off)
> @@ -520,7 +521,7 @@ static int adp5589_gpio_add(struct adp5589_kpad
> *kpad)
>  	kpad->gc.direction_input = adp5589_gpio_direction_input;
>  	kpad->gc.direction_output = adp5589_gpio_direction_output;
>  	kpad->gc.get = adp5589_gpio_get_value;
> -	kpad->gc.set = adp5589_gpio_set_value;
> +	kpad->gc.set_rv = adp5589_gpio_set_value;
>  	kpad->gc.can_sleep = 1;
> 
>  	kpad->gc.base = gpio_data->gpio_start;
> 
> --
> 2.48.1

RE: [PATCH RESEND 2/3] Input: adp5588 - use new GPIO line value setter callbacks

[Hennerich, Michael]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@bgdev.pl>
> Sent: Tuesday, June 10, 2025 11:40 AM
> To: Hennerich, Michael <Michael.Hennerich@analog.com>; Dmitry Torokhov
> <dmitry.torokhov@gmail.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> gpio@vger.kernel.org; Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Subject: [PATCH RESEND 2/3] Input: adp5588 - use new GPIO line value setter
> callbacks
> 
> 
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return an integer,
> allowing to indicate failures. Convert the driver to using them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/keyboard/adp5588-keys.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c
> index
> dc734974ce0687a6e850242b531979be8395b394..2b2aca08423a4ee658d
> b56f77bae25ef5a18e7a6 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -232,8 +232,8 @@ static int adp5588_gpio_get_value(struct gpio_chip
> *chip, unsigned int off)
>  	return !!(val & bit);
>  }
> 
> -static void adp5588_gpio_set_value(struct gpio_chip *chip,
> -				   unsigned int off, int val)
> +static int adp5588_gpio_set_value(struct gpio_chip *chip, unsigned int off,
> +				  int val)
>  {
>  	struct adp5588_kpad *kpad = gpiochip_get_data(chip);
>  	unsigned int bank = ADP5588_BANK(kpad->gpiomap[off]); @@ -
> 246,7 +246,8 @@ static void adp5588_gpio_set_value(struct gpio_chip *chip,
>  	else
>  		kpad->dat_out[bank] &= ~bit;
> 
> -	adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank, kpad-
> >dat_out[bank]);
> +	return adp5588_write(kpad->client, GPIO_DAT_OUT1 + bank,
> +			     kpad->dat_out[bank]);
>  }
> 
>  static int adp5588_gpio_set_config(struct gpio_chip *chip,  unsigned int off,
> @@ -424,7 +425,7 @@ static int adp5588_gpio_add(struct adp5588_kpad
> *kpad)
>  	kpad->gc.direction_input = adp5588_gpio_direction_input;
>  	kpad->gc.direction_output = adp5588_gpio_direction_output;
>  	kpad->gc.get = adp5588_gpio_get_value;
> -	kpad->gc.set = adp5588_gpio_set_value;
> +	kpad->gc.set_rv = adp5588_gpio_set_value;
>  	kpad->gc.set_config = adp5588_gpio_set_config;
>  	kpad->gc.can_sleep = 1;
> 
> 
> --
> 2.48.1

Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[Bartosz Golaszewski]

On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> Never got any further feedback on this series last cycle. Resending for
> v6.17.
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the GPIO controllers under drivers/input/.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Bartosz Golaszewski (3):
>       Input: ad7879 - use new GPIO line value setter callbacks
>       Input: adp5588 - use new GPIO line value setter callbacks
>       Input: adp5589 - use new GPIO line value setter callbacks
>
>  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
>  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
>  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
>  3 files changed, 18 insertions(+), 13 deletions(-)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>

Dmitry,

Could you please pick these patches up for v6.17? They already missed
the last cycle and we're on track to complete the conversion in the
next one so I'd really appreciate these going upstream in the next
merge window.

Bart

Re: [PATCH RESEND 1/3] Input: ad7879 - use new GPIO line value setter callbacks

[Dmitry Torokhov]

On Tue, Jun 10, 2025 at 11:39:58AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry

Re: [PATCH RESEND 2/3] Input: adp5588 - use new GPIO line value setter callbacks

[Dmitry Torokhov]

On Tue, Jun 10, 2025 at 11:39:59AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry

Re: [PATCH RESEND 3/3] Input: adp5589 - use new GPIO line value setter callbacks

[Dmitry Torokhov]

On Tue, Jun 10, 2025 at 11:40:00AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry

Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[Dmitry Torokhov]

Hi Bartosz,

On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > Never got any further feedback on this series last cycle. Resending for
> > v6.17.
> >
> > struct gpio_chip now has callbacks for setting line values that return
> > an integer, allowing to indicate failures. We're in the process of
> > converting all GPIO drivers to using the new API. This series converts
> > all the GPIO controllers under drivers/input/.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > Bartosz Golaszewski (3):
> >       Input: ad7879 - use new GPIO line value setter callbacks
> >       Input: adp5588 - use new GPIO line value setter callbacks
> >       Input: adp5589 - use new GPIO line value setter callbacks
> >
> >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> >  3 files changed, 18 insertions(+), 13 deletions(-)
> > ---
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> >
> > Best regards,
> > --
> > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> 
> Dmitry,
> 
> Could you please pick these patches up for v6.17? They already missed
> the last cycle and we're on track to complete the conversion in the
> next one so I'd really appreciate these going upstream in the next
> merge window.

My apologies, I was hoping Nuno's conversion of these drivers to MFD
would be accepted and these versions be simply removed...

I acked all 3.

Thanks.

-- 
Dmitry

Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[Bartosz Golaszewski]

On Thu, Jun 26, 2025 at 7:54 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Bartosz,
>
> On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> > On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > Never got any further feedback on this series last cycle. Resending for
> > > v6.17.
> > >
> > > struct gpio_chip now has callbacks for setting line values that return
> > > an integer, allowing to indicate failures. We're in the process of
> > > converting all GPIO drivers to using the new API. This series converts
> > > all the GPIO controllers under drivers/input/.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > > Bartosz Golaszewski (3):
> > >       Input: ad7879 - use new GPIO line value setter callbacks
> > >       Input: adp5588 - use new GPIO line value setter callbacks
> > >       Input: adp5589 - use new GPIO line value setter callbacks
> > >
> > >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> > >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> > >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> > >  3 files changed, 18 insertions(+), 13 deletions(-)
> > > ---
> > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> > >
> > > Best regards,
> > > --
> > > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> >
> > Dmitry,
> >
> > Could you please pick these patches up for v6.17? They already missed
> > the last cycle and we're on track to complete the conversion in the
> > next one so I'd really appreciate these going upstream in the next
> > merge window.
>
> My apologies, I was hoping Nuno's conversion of these drivers to MFD
> would be accepted and these versions be simply removed...
>
> I acked all 3.
>
> Thanks.
>
> --
> Dmitry

Does this mean you prefer me to take them through the GPIO tree? Do
you want an immutable branch?

Bart

Re: [PATCH RESEND 0/3] Input: convert GPIO chips to using new value setters

[Dmitry Torokhov]

On Thu, Jun 26, 2025 at 09:37:08AM +0200, Bartosz Golaszewski wrote:
> On Thu, Jun 26, 2025 at 7:54 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Hi Bartosz,
> >
> > On Mon, Jun 23, 2025 at 09:59:07AM +0200, Bartosz Golaszewski wrote:
> > > On Tue, Jun 10, 2025 at 11:40 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > Never got any further feedback on this series last cycle. Resending for
> > > > v6.17.
> > > >
> > > > struct gpio_chip now has callbacks for setting line values that return
> > > > an integer, allowing to indicate failures. We're in the process of
> > > > converting all GPIO drivers to using the new API. This series converts
> > > > all the GPIO controllers under drivers/input/.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > > ---
> > > > Bartosz Golaszewski (3):
> > > >       Input: ad7879 - use new GPIO line value setter callbacks
> > > >       Input: adp5588 - use new GPIO line value setter callbacks
> > > >       Input: adp5589 - use new GPIO line value setter callbacks
> > > >
> > > >  drivers/input/keyboard/adp5588-keys.c |  9 +++++----
> > > >  drivers/input/keyboard/adp5589-keys.c | 11 ++++++-----
> > > >  drivers/input/touchscreen/ad7879.c    | 11 +++++++----
> > > >  3 files changed, 18 insertions(+), 13 deletions(-)
> > > > ---
> > > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > > change-id: 20250331-gpiochip-set-rv-input-bc12818c5732
> > > >
> > > > Best regards,
> > > > --
> > > > Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > >
> > > Dmitry,
> > >
> > > Could you please pick these patches up for v6.17? They already missed
> > > the last cycle and we're on track to complete the conversion in the
> > > next one so I'd really appreciate these going upstream in the next
> > > merge window.
> >
> > My apologies, I was hoping Nuno's conversion of these drivers to MFD
> > would be accepted and these versions be simply removed...
> >
> > I acked all 3.
> >
> > Thanks.
> >
> > --
> > Dmitry
> 
> Does this mean you prefer me to take them through the GPIO tree? Do
> you want an immutable branch?

Ah, my bad, I thought there was dependency on -next for these. I applied
them and sorry for the delay.

Thanks.

-- 
Dmitry