Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Richard Knutsson
2008-01-09T13:17:54Z

Andre Noll wrote:
> On 17:40, Andi Kleen wrote:
>
>
>> Here's a proposal for some useful code transformations the kernel janitors
>> could do as opposed to running checkpatch.pl.
>>
>
> Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64.
>
... and x86 with all(yes|mod)config. :)

Would had preferred:

if (x) {
result = -Exxxx;
goto out;
}

then:

result = -Exxxx;
if (x)
goto out;

but it looks correct.

cu,
Richard