Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Rik van Riel
2008-01-08T20:23:00Z

On Tue, 8 Jan 2008 20:58:04 +0100
"Paolo Ciarrocchi" <paolo.ciarrocchi@gmail.com> wrote:

> -static const struct file_operations rtc_fops = {
> +static long rtc_fioctl(struct file_operations rtc_fops)
> +{
> + lock_kernel();
> .owner = THIS_MODULE,
> .llseek = no_llseek,
> .read = rtc_read,
> .poll = rtc_poll,
> - .ioctl = rtc_ioctl,
> + .unlocked_ioctl = rtc_ioctl,
> .open = rtc_open,
> .release = rtc_release,
> .fasync = rtc_fasync,
> + unlock_kernel();
> };

This is a struct with function pointers, not a function.

No wonder it doesn't compile after you tried turning it into one :)

--
All rights reversed.