The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	James Smart <james.smart@broadcom.com>,
	"James E. J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/4] scsi: lpfc: Delete an unnecessary return statement in lpfc_sli_read_link_ste()
Date: Thu, 28 Dec 2023 18:26:06 +0100	[thread overview]
Message-ID: <8007263d-fe17-454e-92f3-cde218b7ed4f@web.de> (raw)
In-Reply-To: <48a127e8-ca4f-4fc4-81b7-226080fba720@web.de>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 28 Dec 2023 17:45:29 +0100

The script “checkpatch.pl” pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/lpfc/lpfc_sli.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 93339425ce3c..8de598c9e03b 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -20778,7 +20778,6 @@ lpfc_sli_read_link_ste(struct lpfc_hba *phba)

 out:
 	kfree(rgn23_data);
-	return;
 }

 /**
--
2.43.0


  parent reply	other threads:[~2023-12-28 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 17:20 [PATCH 0/4] scsi: lpfc: Adjustments for two function implementations Markus Elfring
2023-12-28 17:22 ` [PATCH 1/4] scsi: lpfc: Improve exception handling in lpfc_rcv_plogi() Markus Elfring
2023-12-28 17:24 ` [PATCH 2/4] scsi: lpfc: Return directly after a failed kzalloc() in lpfc_sli_read_link_ste() Markus Elfring
2023-12-28 17:26 ` Markus Elfring [this message]
2023-12-28 17:28 ` [PATCH 4/4] scsi: lpfc: Delete an unnecessary variable initialisation " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8007263d-fe17-454e-92f3-cde218b7ed4f@web.de \
    --to=markus.elfring@web.de \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox