From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: keescook@chromium.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-integrity@vger.kernel.org,
labbott@redhat.com
Subject: Re: [PATCH] tpm: handle negative priv->response_len in tpm_common_read
Date: Wed, 08 Jan 2020 18:04:49 +0200 [thread overview]
Message-ID: <80272f0259d967fe61dacd1036cbbd9f555b8402.camel@linux.intel.com> (raw)
In-Reply-To: <b469b7e8454a69402529cc8e25244860e136308e.camel@linux.intel.com>
On Wed, 2020-01-08 at 17:58 +0200, Jarkko Sakkinen wrote:
> On Tue, 2020-01-07 at 14:04 -0800, Tadeusz Struk wrote:
> > The priv->responce_length can hold the size of an response or
> > an negative error code, and the tpm_common_read() needs to handle
> > both cases correctly. Changed the type of responce_length to
> > signed and accounted for negative value in tpm_common_read()
> >
> > Cc: stable@vger.kernel.org
> > Fixes: d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
> > Reported-by: Laura Abbott <labbott@redhat.com>
> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Adding to the next PR.
Applied but had to fix bunch of typos, missing punctaction and
missing parentheses in the commit message. Even checkpatch.pl
was complaining :-/
Thanks.
/Jarkko
next prev parent reply other threads:[~2020-01-08 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 18:51 Bad usercopy from tpm after d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode") Laura Abbott
2020-01-07 20:27 ` Tadeusz Struk
2020-01-07 22:04 ` [PATCH] tpm: handle negative priv->response_len in tpm_common_read Tadeusz Struk
2020-01-08 15:58 ` Jarkko Sakkinen
2020-01-08 16:04 ` Jarkko Sakkinen [this message]
2020-01-08 17:47 ` Tadeusz Struk
2020-01-13 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80272f0259d967fe61dacd1036cbbd9f555b8402.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox