From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752914AbbDUIrq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Apr 2015 04:47:46 -0400
Received: from mout.kundenserver.de ([212.227.17.13]:50712 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751486AbbDUIrl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Apr 2015 04:47:41 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Baolin Wang <baolin.wang@linaro.org>, Thomas Gleixner <tglx@linutronix.de>,
        Xunlei Pang <pang.xunlei@linaro.org>, peterz@infradead.org,
        benh@kernel.crashing.org, heiko.carstens@de.ibm.com, paulus@samba.org,
        cl@linux.com, Heena Sirwani <heenasirwani@gmail.com>,
        linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
        mpe@ellerman.id.au, rafael.j.wysocki@intel.com,
        Andrew Hunter <ahh@google.com>,
        =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        Paul Turner <pjt@google.com>, riel@redhat.com,
        Richard Cochran <richardcochran@gmail.com>, schwidefsky@de.ibm.com,
        John Stultz <john.stultz@linaro.org>, rth@twiddle.net,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, tj@kernel.org, linux390@de.ibm.com,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions
Date: Tue, 21 Apr 2015 10:45:48 +0200
Message-ID: <8072977.i0FsrGW3CD@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAMz4kuKF2sU4tMD7UtDobu2kVDMp7cfHNERSPQ9Yyzs80tOzYg@mail.gmail.com>
References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> <alpine.DEB.2.11.1504202243070.13914@nanos> <CAMz4kuKF2sU4tMD7UtDobu2kVDMp7cfHNERSPQ9Yyzs80tOzYg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:F1IjvL2hAhkwmREKhxXF1ljpFrorkWuSloVMxYQ4W+Nf0Yyw5mz
 1Kij+1F1ljdddfr/OgMwsMccnR3LyBY/BtIVd76i0MPazsQzXMThOcH17j5we1QbFJkTx8L
 6ArAIBnXc+qxQb87Be+ao5eee2ApHsefC03ZDaAPL225Z5pH5CCOe+lY2WrISDRMLWcsWsC
 qQpK1CPyGgcDUOC3FlPXA==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 21 April 2015 16:36:13 Baolin Wang wrote:
> On 21 April 2015 at 04:48, Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > On Mon, 20 Apr 2015, Baolin Wang wrote:
> > >  /* Set clock_realtime */
> > >  static int posix_clock_realtime_set(const clockid_t which_clock,
> > > -                                 const struct timespec *tp)
> > > +                                 const struct timespec64 *tp)
> > >  {
> > > -     return do_sys_settimeofday(tp, NULL);
> > > +     struct timespec ts = timespec64_to_timespec(*tp);
> > > +
> > > +     return do_sys_settimeofday(&ts, NULL);
> >
> > Sigh. No. We first provide a proper function for this, which takes a
> > timespec64, i.e. do_sys_settimeofday64() instead of having this
> > wrapper mess all over the place.
> >
> 
> Thanks for your comments,but if use do_sys_settimeofday64() here that
> will  introduce
> a security bug: do_sys_settimeofday contains a capability
> check that normally prevents non-root users from setting the time.
> 
> With your change, any user can set the system time.

He was asking for a new do_sys_settimeofday64 function to be added,
not using the low-level do_settimeofday64.

	Arnd