public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luben Tuikov <ltuikov@yahoo.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] [USB] UAS: Rename urbs by pipe
Date: Thu, 28 Oct 2010 14:43:31 -0700 (PDT)	[thread overview]
Message-ID: <807665.54188.qm@web31802.mail.mud.yahoo.com> (raw)
In-Reply-To: <20101028204101.GA22785@kroah.com>

--- On Thu, 10/28/10, Greg KH <greg@kroah.com> wrote:
> I'm sorry, but can you explain this a bit more?  I
> really don't
> understand why this change is necessary.

It isn't necessary (like water or food, etc). It reflects much closer what
really is happening under the hood. Having a software abstraction
(implementation) representing the hw or the physical function much closer,
allows for much more versatile manipulation.

For example, if you would like to implement sending TMFs and receiving
their Responses, you'd do that on the Command and Status pipes. So you can
allocate an URB at the "cmd_urb" (meaning "command pipe urb") and on the
"status_urb" (meaning "status pipe urb"). Before this patch this was called
"sense_urb" which reflected what the type of IU but not the pipe, all the
while it was being allocated for the Status pipe. A good infrastructure
is a reusable infrastructure. This patch properly renames some macro
definitions and variables in order to allow for some of the infrastructure
of the driver to be reused in order to send other IUs.


  reply	other threads:[~2010-10-28 21:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-28 20:05 [PATCH] [USB] UAS: Rename urbs by pipe Luben Tuikov
2010-10-28 20:41 ` Greg KH
2010-10-28 21:43   ` Luben Tuikov [this message]
2010-11-08 11:22 ` Matthew Wilcox
2010-11-08 17:17   ` Luben Tuikov
2010-12-01  1:07 ` Greg KH
2010-12-02 21:40   ` Matthew Wilcox
2010-12-02 22:26     ` Luben Tuikov
2010-12-03  0:07       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2010-11-08 17:52 Luben Tuikov
2010-12-10 10:50 Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=807665.54188.qm@web31802.mail.mud.yahoo.com \
    --to=ltuikov@yahoo.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox