Re: [patch V4 part 3 29/29] x86/entry/32: Convert IRET exception to IDTENTRY_SW

Thomas Gleixner
2020-05-15T14:12:06Z

Andy Lutomirski <luto@kernel.org> writes:

> On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> Convert the IRET exception handler to IDTENTRY_SW. This is slightly
>> different than the conversions of hardware exceptions as the IRET exception
>> is invoked via an exception table when IRET faults. So it just uses the
>> IDTENTRY_SW mechanism for consistency. It does not emit ASM code as it does
>> not fit the other idtentry exceptions.
>
> Blech. I should redo the 32-bit code to handle this the way the
> 64-bit code does and this can all be deleted. But, for now:
>
> Acked-by: Andy Lutomirski <luto@kernel.org>
>
> However, maybe rename asm_exc_iret_error to avoid confusion? It's not
> really an exception entry.

True. Removed the 'exc_' from all instances.