From: David Howells <dhowells@redhat.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: dhowells@redhat.com, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/keys/system_keyring.h: fix building error
Date: Sat, 19 Jan 2013 01:02:46 +0000 [thread overview]
Message-ID: <8083.1358557366@warthog.procyon.org.uk> (raw)
In-Reply-To: <1358556813-12518-1-git-send-email-dinggnu@gmail.com>
Cong Ding <dinggnu@gmail.com> wrote:
> When I am doing "make randconfig", it causes the following building error if
> CONFIG_SYSTEM_TRUSTED_KEYRING is not defined and CONFIG_MODULE_SIG is defined.
Can you tell me what you're doing your build upon?
> -#ifdef CONFIG_SYSTEM_TRUSTED_KEYRING
> +#if defined(CONFIG_SYSTEM_TRUSTED_KEYRING) || defined(CONFIG_MODULE_SIG)
This isn't the right way to do it: CONFIG_MODULE_SIG should require
CONFIG_SYSTEM_TRUSTED_KEYRING to be "=y" otherwise you don't get the .c file
either. Can you check that it isn't "=m"?
David
next prev parent reply other threads:[~2013-01-19 1:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 0:53 [PATCH] include/keys/system_keyring.h: fix building error Cong Ding
2013-01-19 1:02 ` David Howells [this message]
2013-01-19 1:08 ` Cong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8083.1358557366@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dinggnu@gmail.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox