From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750931AbdAWBat (ORCPT ); Sun, 22 Jan 2017 20:30:49 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11033 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdAWBas (ORCPT ); Sun, 22 Jan 2017 20:30:48 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Sun, 22 Jan 2017 05:26:05 -0800 Subject: Re: [PATCH] mm: do not export ioremap_page_range symbol for external module To: zhong jiang , , , References: <1485089881-61531-1-git-send-email-zhongjiang@huawei.com> <588558EB.2060505@huawei.com> CC: , X-Nvconfidentiality: public From: John Hubbard Message-ID: <8088cdd7-7abb-94ed-3bea-44d819045573@nvidia.com> Date: Sun, 22 Jan 2017 17:30:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <588558EB.2060505@huawei.com> X-Originating-IP: [172.17.160.221] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2017 05:14 PM, zhong jiang wrote: > On 2017/1/22 20:58, zhongjiang wrote: >> From: zhong jiang >> >> Recently, I find the ioremap_page_range had been abusing. The improper >> address mapping is a issue. it will result in the crash. so, remove >> the symbol. It can be replaced by the ioremap_cache or others symbol. >> >> Signed-off-by: zhong jiang >> --- >> lib/ioremap.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/lib/ioremap.c b/lib/ioremap.c >> index 86c8911..a3e14ce 100644 >> --- a/lib/ioremap.c >> +++ b/lib/ioremap.c >> @@ -144,4 +144,3 @@ int ioremap_page_range(unsigned long addr, >> >> return err; >> } >> -EXPORT_SYMBOL_GPL(ioremap_page_range); > self nack > heh. What changed your mind?