From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbcAGXWu (ORCPT ); Thu, 7 Jan 2016 18:22:50 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36537 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcAGXWs (ORCPT ); Thu, 7 Jan 2016 18:22:48 -0500 User-Agent: K-9 Mail for Android In-Reply-To: References: <20160107215945.GA19314@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [RFC] perf record: missing buildid for callstack modules From: Namhyung Kim Date: Fri, 08 Jan 2016 07:47:03 +0900 To: Stephane Eranian , Arnaldo Carvalho de Melo CC: LKML , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Adrian Hunter , "ak@linux.intel.com" Message-ID: <80F05A66-6943-499A-B402-96249953CD15@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On January 8, 2016 7:00:35 AM GMT+09:00, Stephane Eranian wrote: >On Thu, Jan 7, 2016 at 1:59 PM, Arnaldo Carvalho de Melo > wrote: >> Em Thu, Jan 07, 2016 at 01:56:14PM -0800, Stephane Eranian escreveu: >>> Hi, >>> >>> Whenever you do: >>> >>> $ perf record -g -a sleep 10 >>> >>> Perf will collect the callstack for each sample. At the end of the >>> run, perf record >>> adds the buildid for all dso with at least one sample. But when it >does this, it >>> only looks at the sampled IP and ignore the modules traversed by the >callstack. >>> That means that, it is not possible to uniquely identify the modules >executed, >>> unless they had at least one IP sample captured. But this is not >>> always the case. >>> >>> How about providing an option to perf record to force collecting >>> buildid for all IPs >>> captured in the callstack? I understand that would cost more at the >end of the >>> collection, but this would be beneficial to several monitoring >scenarios. >> >> I agree, would consider applying a patch that provides the option but >> does not do this by default. >> >I agree, not the default. Hi Stephane, Please see https://lkml.org/lkml/2015/3/22/249 Thanks, Namhyung -- Sent from my Android device with K-9 Mail. Please excuse my brevity.