From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751139AbdLWHNR (ORCPT <rfc822;w@1wt.eu>);
        Sat, 23 Dec 2017 02:13:17 -0500
Received: from mout.web.de ([217.72.192.78]:50148 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750727AbdLWHNO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 23 Dec 2017 02:13:14 -0500
Subject: Re: platform/x86/thinkpad_acpi: Adjustments for four function
 implementations
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
        ibm-acpi-devel@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Andy Shevchenko <andy@infradead.org>,
        Darren Hart <dvhart@infradead.org>,
        Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net>
 <CAHp75Vckgw1Eqao_vsq0n8RuYJRP2JZWJz6-MxZ6Wwb8eAEVgA@mail.gmail.com>
 <ea910da9-ca59-b895-b071-35d9c5cbd112@users.sourceforge.net>
 <20171223014033.jx7fzu7uzjfbzyca@khazad-dum.debian.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <80ae8328-5851-01b0-cb31-474f7baf1686@users.sourceforge.net>
Date: Sat, 23 Dec 2017 08:12:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171223014033.jx7fzu7uzjfbzyca@khazad-dum.debian.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:ZtSQGbok257P9bSGJIS8xzIyTVgRw2DGoN//CfKL0uRLX0oVvlM
 Z3vTnx3+UOTqLnBahb0jCX6BKaRk6QFS0J99aW0wRNXJAl1XrkZmo9jbbwFc82kQ8WbBjJG
 5YN+jYELhtoNpp5wAv2o752tYyY/l0Sg7wuACJb3Sga37D58uorhqeo6bOR97VfDZYro17o
 /co68+LVZ2GSujJWkg6DQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:PzVor4Wo2uU=:/VTMvpY5l88n74KZpduJmU
 e0ILk+6x3gWOEizCS5eQsLuFDn55mTKiEcOknjOxJWrGUEzOWb7k6U6HHszfxfClGH/mIMaxZ
 v9fa1Dyo3fcOb9B4K0La2KiEdx6neSb+JYybWUmpDG0x3WQXPUL8MfbWFCtV9sdie1UQjQain
 nOu2YwTdO6qlwteYGZYi+CBNgWHlGVVjXoQupH6jOLF62zNe3/lp8eXa6vSPZk7T5wAUz9O/R
 2bzzF74LZemhZZRgLs3inRoV7H17EiRfgYGx8Ol92YUkySA6vq4X1Cy98R+j+jCPIGJn8j1VD
 i6YWvG1SDxu1nqYBKGvXT6AtFX3ys3xbwKP5vlZUgY0aDbKWhws/KtJGPRdI3f3xgyrPRT/l3
 5Zb0TClT3GuBat6yjsedvyQ/+SC71FyDU8kiJPXkATgipOzE7adRgdwuHq8OPM6M5IKvR1s/n
 nVv3nI08rgG6wswAsLinpJ2soPsh43QqkzgcI/7zHgto9QlZhkCWJ/71h8vYj9rJIGf9xlgHN
 werQietdl2gwIeVEq2ph2iE3sMmBDvTxyIcwWlsk4DI/EbJXBSQwbhTs+PjguKV3i+37iubvR
 tSYSqZ5w1dv4SwHMxtwc0PIKU8Ai+ZGA+NoNF8JsynZWFnP0tMl4lpwxHrJbtRQZSGFmw4KY3
 ExHvJZEQlpZjjd5OHfv7BbjtN/NWEZ0WZvZSmFEGZJPxuSVDYVOscM63aKlM8vFuzS+30kBiV
 BoS5KwEP9U4Uk25yChxi1jIzolwQJ0Nb8Z3hGyNNVIaGJlYvEeaUbKQXM0x8EI6YmG4NyY7dL
 3Gysq0e3cIwVgqQlqJlyWAIcSAvrxRyThtW/PoYmKDUIuNTDDA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Do you find the Linux allocation failure report insufficient in this case?
> 
> Leave those pr_ messages alone, please,

Have you got special software development concerns?


> unless they are really causing some sort of issue (which?).

Can the code be redundant here?


> Doing it just for "compliance" with a doc isn't nearly good enough reason.

Do you give only a low value to coding style guidelines in this use case?

Regards,
Markus