From: Jiri Slaby <jirislaby@kernel.org>
To: Emil Kronborg <emil.kronborg@protonmail.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: mxs-auart broken in v6.2 and onwards
Date: Wed, 31 Jan 2024 13:15:45 +0100 [thread overview]
Message-ID: <80b84147-e27d-4110-843f-700e738b50ad@kernel.org> (raw)
In-Reply-To: <djtgk274iojly23xjb6kgx7ucgv6a4d23ix4vvr2cfskrkeb2r@uykelfkgrcg7>
On 30. 01. 24, 19:57, Emil Kronborg wrote:
> Hi,
>
> On Tue, Jan 30, 2024 at 10:38 +0100, Jiri Slaby wrote:
>> Hm, the tx stop handling is weird throughout mxs. What about the
>> attached patch?
>
> It seems to fix the issue, but I do not see any way to fix this just for
> mxs-auart.c without also changing serial_core.h, and thus affecting a
> bunch of other drivers.
Hi, the fix I sent to you does not affect any other driver. (Even when
it touches serial_core.h.)
> Would reverting the changes from 2d141e683e9a
> ("tty: serial: use uart_port_tx() helper") for just mxs-auart.c be okay?
Nope.
> If so, I can do that, test it again, and send a patch.
I've sent proper patches to fix the issue. If you can retest, please add
your Tested-by line in there.
thanks,
--
js
suse labs
prev parent reply other threads:[~2024-01-31 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 21:35 mxs-auart broken in v6.2 and onwards Emil Kronborg
2024-01-30 9:38 ` Jiri Slaby
2024-01-30 18:57 ` Emil Kronborg
2024-01-31 12:15 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b84147-e27d-4110-843f-700e738b50ad@kernel.org \
--to=jirislaby@kernel.org \
--cc=emil.kronborg@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox