From: Shreenidhi Shedi <yesshedi@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: dhowells@redhat.com, dwmw2@infradead.org, masahiroy@kernel.org,
nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu,
linux-kernel@vger.kernel.org, sshedi@vmware.com,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v7 8/8] kbuild: modinst: do modules_install step by step
Date: Mon, 7 Aug 2023 16:48:24 +0530 [thread overview]
Message-ID: <80bd4203-471a-4e47-8799-e6c0e70c9c24@gmail.com> (raw)
In-Reply-To: <2023080630-entomb-ogle-3da8@gregkh>
On 06/08/23 12:15, Greg KH wrote:
> On Sun, Aug 06, 2023 at 12:30:22AM +0530, Shreenidhi Shedi wrote:
>> On 04/08/23 19:36, Greg KH wrote:
>>> On Fri, Jun 23, 2023 at 08:23:58PM +0530, Shreenidhi Shedi wrote:
>>>> Currently Makefile.modinst does three tasks on each module built:
>>>> - Install modules
>>>> - Sign modules
>>>> - Compress modules
>>>>
>>>> All the above tasks happen from a single place.
>>>>
>>>> This patch divides this task further and uses a different makefile for
>>>> each task.
>>>> Signing module logic is completely refactored and everything happens
>>>> from a shell script now.
>>>>
>>>> Signed-off-by: Shreenidhi Shedi <yesshedi@gmail.com>
>>>> ---
>>>> scripts/Makefile.compress | 53 ++++++++++++++++++
>>>> scripts/Makefile.install | 66 +++++++++++++++++++++++
>>>> scripts/Makefile.modinst | 111 +++-----------------------------------
>>>> scripts/Makefile.sign | 37 +++++++++++++
>>>> scripts/signfile.sh | 24 +++++++++
>>>> 5 files changed, 186 insertions(+), 105 deletions(-)
>>>> create mode 100644 scripts/Makefile.compress
>>>> create mode 100644 scripts/Makefile.install
>>>> create mode 100644 scripts/Makefile.sign
>>>> create mode 100755 scripts/signfile.sh
>>>
>>> As you are touching the build process, you should always cc: the proper
>>> mailing list, and the KBUILD maintainer. Please do so for this series,
>>> as that is the proper tree for this to go through.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Thanks for the inputs Greg.
>>
>> CC-ing linux-kbuild@vger.kernel.org as suggested.
>
> This doesn't actually do anything, sorry. Please resend the whole
> patchset again and add the proper people and list.
>
> thanks,
>
> greg k-h
Done. Addressed comments from Masahiro Yamada and sent a new patch
series, hopefully I have added everyone this time :) Thanks.
--
Shedi
next prev parent reply other threads:[~2023-08-07 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 14:53 [PATCH v7 0/8] refactor file signing program Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 1/8] sign-file: use getopt_long_only for parsing input args Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 2/8] sign-file: inntroduce few new flags to make argument processing easy Shreenidhi Shedi
2023-08-07 2:35 ` Masahiro Yamada
2023-08-07 7:57 ` Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 3/8] sign-file: move file signing logic to its own function Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 4/8] sign-file: add support to sign modules in bulk Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 5/8] sign-file: improve help message Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 6/8] sign-file: use const with a global string constant Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 7/8] sign-file: fix do while styling issue Shreenidhi Shedi
2023-06-23 14:53 ` [PATCH v7 8/8] kbuild: modinst: do modules_install step by step Shreenidhi Shedi
2023-08-04 14:06 ` Greg KH
2023-08-05 19:00 ` Shreenidhi Shedi
2023-08-06 6:45 ` Greg KH
2023-08-07 11:18 ` Shreenidhi Shedi [this message]
2023-08-06 19:32 ` Masahiro Yamada
2023-08-07 8:08 ` Shreenidhi Shedi
2023-08-07 18:44 ` Masahiro Yamada
2023-08-09 17:27 ` Shreenidhi Shedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80bd4203-471a-4e47-8799-e6c0e70c9c24@gmail.com \
--to=yesshedi@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=sshedi@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox