From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>,
kpallavi@qti.qualcomm.com, srini@kernel.org,
amahesh@qti.qualcomm.com, arnd@arndb.de,
gregkh@linuxfoundation.org
Cc: quic_bkumar@quicinc.com, ekansh.gupta@oss.qualcomm.com,
linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
jingyi.wang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com,
ktadakam@qti.qualcomm.com
Subject: Re: [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Date: Mon, 17 Nov 2025 08:20:28 +0100 [thread overview]
Message-ID: <80ce9e2e-3e18-4782-aa6a-2b6913c327df@kernel.org> (raw)
In-Reply-To: <73e6b7b9-7ecc-4137-aaa7-43a7fd950168@oss.qualcomm.com>
On 17/11/2025 08:17, Kumari Pallavi wrote:
>
>
> On 11/14/2025 9:17 PM, Krzysztof Kozlowski wrote:
>> On 14/11/2025 09:41, Kumari Pallavi wrote:
>>> Add a new compatible string "qcom,kaanapali-fastrpc" to support
>>> for Kaanapali SoC.
>>>
>>> Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
>>> ---
>>
>> You not only did not bother to test it - there are obvious bugs here -
>> but you also did not send it to mailing lists for actual testing by
>> Rob's bot.
>>
>> NAK
>>
>> Best regards,
>> Krzysztof
>
> Thank you for the feedback. I did run the schema validation locally using:
> make dt_binding_check
> (as per
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/),
> and the build completed successfully without any errors.
But you did not read warnings and messages shown to you...
That's still obviously NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-17 7:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 8:41 [PATCH v3 0/4] Add ADSP and CDSP support on Kaanapali SoC Kumari Pallavi
2025-11-14 8:41 ` [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali Kumari Pallavi
2025-11-14 15:47 ` Krzysztof Kozlowski
2025-11-17 7:17 ` Kumari Pallavi
2025-11-17 7:20 ` Krzysztof Kozlowski [this message]
2025-11-14 8:41 ` [PATCH v3 2/4] misc: fastrpc: Rename phys to dma_addr for clarity Kumari Pallavi
2025-11-14 12:15 ` Dmitry Baryshkov
2025-11-17 7:03 ` Kumari Pallavi
2025-11-14 15:44 ` Bjorn Andersson
2025-11-17 7:07 ` Kumari Pallavi
2025-11-17 11:22 ` Dmitry Baryshkov
2025-11-17 11:31 ` Konrad Dybcio
2025-11-18 16:04 ` Bjorn Andersson
2025-11-14 8:41 ` [PATCH v3 3/4] misc: fastrpc: Add support for new DSP IOVA formatting Kumari Pallavi
2025-11-14 15:51 ` Bjorn Andersson
2025-11-17 7:02 ` Kumari Pallavi
2025-11-18 15:52 ` Bjorn Andersson
2025-11-14 8:41 ` [PATCH v3 4/4] misc: fastrpc: Update dma_bits for CDSP support on Kaanapali SoC Kumari Pallavi
2025-11-14 16:00 ` Bjorn Andersson
2025-11-17 9:12 ` Kumari Pallavi
2025-11-18 16:57 ` Bjorn Andersson
2025-11-24 11:21 ` Kumari Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ce9e2e-3e18-4782-aa6a-2b6913c327df@kernel.org \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=amahesh@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=kpallavi@qti.qualcomm.com \
--cc=ktadakam@qti.qualcomm.com \
--cc=kumari.pallavi@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox