From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D42378824 for ; Tue, 25 Aug 2026 06:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639769; cv=none; b=ELLuinHWIiHJ4kk7jdnr5FulHlU9nlTNfZ2j2enDUXyP8LqiRSZKa0OQbWd739i07n2T65ll/pslvvtgKG5NBWFBZymTWOAe5Pz/gL+bnPFqMjh6zrN4HJQxA8PDkEjlo7siE5+b6gQi9NYFeVDI3THP3Lb+AooQ8OWV31WQ+7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639769; c=relaxed/simple; bh=Hd0sC7tk86QoYXGWWWx21TcO2qb62Hd5/T576iXGYYI=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=nHGctgSrIAXqKk7DyK6fX1iOEKCzLN/fbb4mBxpvTkZ0Q9ZVSYB+rtdTP3mEd0Zq2SYsGknH/vIZclh08RTgc2dVUhN+AIHOIoGE7kgAe+Phxe0V4Y0kP0XiKPnJrwGzVfWNiGPSTOe2Fg0+5uEATwU1Jf4bQTpRWfLu6rZGArY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jpPphzTL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jpPphzTL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E5361F000E9; Tue, 25 Aug 2026 06:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787639768; bh=h6uheborK9kDsnT166ceQL15+6H7t38OLGChs04wgko=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=jpPphzTLzA5lfTsvuSCJU7WZyCU/MlYpMbphSlCpf8n2iWkvZkSJyG30AFzLW8PKL RARaq/a+PH+YokM9eeYEL5Nkq4wlYjLsOYDf4+vEDKGOHMupCCEmLbOdSi8n0lXXmu tUn38wugnFDIUf7uqGjSSnIq7OWFTvEN7KJp7z1ffBh3diQWB0q+O2U+dKNsIexhR+ 4ejcnU+QM3B0e+fnHMQUIqK0ntXlS2RXDMA1SpDWkhKutel4N/5Qf5dyopLmpio1af N6xyqi8xBpJ6/aJHvNjuTIcuvTaFpqX6a37LgYCtMfIAUwnjnsL1kGUHaqPPEy7VJy oeJ6oEbBNj66w== Message-ID: <80da6dab-220e-42a3-bbad-a793d653ee37@kernel.org> Date: Tue, 25 Aug 2026 14:36:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 03/12] f2fs: cache: introduce shrinker To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-4-chao@kernel.org> <20260825054205.397297-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825054205.397297-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:42, Wenjie Qi wrote: > Hi Chao, > >> static unsigned long __count_cache(struct f2fs_sb_info *sbi) >> { >> return sbi->meta_blocks.num_entries + >> sbi->node_blocks.num_entries; >> } > > and the scan path includes: > >> freed += f2fs_do_shrink_cache(COMPRESS_CACHE(sbi), >> nr_to_scan - freed); > > The count path includes the meta and node caches, while the scan path also > includes `COMPRESS_CACHE`. > > Is `COMPRESS_CACHE` intentionally excluded from `__count_cache()` even though > `f2fs_shrink_cache()` scans it? Oh, I missed to add it, will fix. Thanks,