linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regulator: RT5133: add missing HAS_IOMEM dependency
@ 2025-08-15  2:27 Randy Dunlap
  2025-08-31  2:24 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2025-08-15  2:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Jeff Chang, Mark Brown, Liam Girdwood

When building on ARCH=um (which does not set HAS_IOMEM), kconfig
reports an unmet dependency caused by REGULATOR_RT5133. It selects
OF_GPIO, which depends on HAS_IOMEM. To stop this warning,
REGULATOR_RT5133 should also depend on HAS_IOMEM.

kconfig warning:
WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
  Selected by [y]:
  - REGULATOR_RT5133 [=y] && REGULATOR [=y] && I2C [=y] && GPIOLIB [=y] && OF [=y]

Fixes: 714165e1c4b0 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jeff Chang <jeff_chang@richtek.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>

 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20250814.orig/drivers/regulator/Kconfig
+++ linux-next-20250814/drivers/regulator/Kconfig
@@ -1251,6 +1251,7 @@ config REGULATOR_RT5120
 config REGULATOR_RT5133
 	tristate "Richtek RT5133 PMIC Regulators"
 	depends on I2C && GPIOLIB && OF
+	depends on HAS_IOMEM
 	select REGMAP
 	select CRC8
 	select OF_GPIO

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: RT5133: add missing HAS_IOMEM dependency
  2025-08-15  2:27 [PATCH] regulator: RT5133: add missing HAS_IOMEM dependency Randy Dunlap
@ 2025-08-31  2:24 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2025-08-31  2:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jeff Chang, Mark Brown, Liam Girdwood

Hi,

On 8/14/25 7:27 PM, Randy Dunlap wrote:
> When building on ARCH=um (which does not set HAS_IOMEM), kconfig
> reports an unmet dependency caused by REGULATOR_RT5133. It selects
> OF_GPIO, which depends on HAS_IOMEM. To stop this warning,
> REGULATOR_RT5133 should also depend on HAS_IOMEM.
> 
> kconfig warning:
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n]
>   Selected by [y]:
>   - REGULATOR_RT5133 [=y] && REGULATOR [=y] && I2C [=y] && GPIOLIB [=y] && OF [=y]
> 
> Fixes: 714165e1c4b0 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jeff Chang <jeff_chang@richtek.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> 
>  drivers/regulator/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20250814.orig/drivers/regulator/Kconfig
> +++ linux-next-20250814/drivers/regulator/Kconfig
> @@ -1251,6 +1251,7 @@ config REGULATOR_RT5120
>  config REGULATOR_RT5133
>  	tristate "Richtek RT5133 PMIC Regulators"
>  	depends on I2C && GPIOLIB && OF
> +	depends on HAS_IOMEM
>  	select REGMAP
>  	select CRC8
>  	select OF_GPIO


Ping. Any comments?

thanks.
-- 
~Randy


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-31  2:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-15  2:27 [PATCH] regulator: RT5133: add missing HAS_IOMEM dependency Randy Dunlap
2025-08-31  2:24 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).