From: Jijie Shao <shaojijie@huawei.com>
To: Tianling Shen <cnsztl@gmail.com>,
Frank Sae <Frank.Sae@motor-comm.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <shaojijie@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531
Date: Mon, 27 Oct 2025 14:11:23 +0800 [thread overview]
Message-ID: <80fb8bee-20bf-4eea-9719-045e85f8f181@huawei.com> (raw)
In-Reply-To: <20251026133652.1288732-1-cnsztl@gmail.com>
on 2025/10/26 21:36, Tianling Shen wrote:
> The LED registers on YT8531 are exactly same as YT8521, so simply
> reuse yt8521_led_hw_* functions.
>
> Tested on OrangePi R1 Plus LTS and Zero3.
>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
Reviewed-by: Jijie Shao<shaojijie@huawei.com>
> ---
> drivers/net/phy/motorcomm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> index a3593e663059..89b5b19a9bd2 100644
> --- a/drivers/net/phy/motorcomm.c
> +++ b/drivers/net/phy/motorcomm.c
> @@ -3048,6 +3048,9 @@ static struct phy_driver motorcomm_phy_drvs[] = {
> .get_wol = ytphy_get_wol,
> .set_wol = yt8531_set_wol,
> .link_change_notify = yt8531_link_change_notify,
> + .led_hw_is_supported = yt8521_led_hw_is_supported,
> + .led_hw_control_set = yt8521_led_hw_control_set,
> + .led_hw_control_get = yt8521_led_hw_control_get,
> },
> {
> PHY_ID_MATCH_EXACT(PHY_ID_YT8531S),
next prev parent reply other threads:[~2025-10-27 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 13:36 [PATCH] net: phy: motorcomm: Add support for PHY LEDs on YT8531 Tianling Shen
2025-10-27 2:10 ` Andrew Lunn
2025-10-27 9:40 ` Tianling Shen
2025-10-27 6:11 ` Jijie Shao [this message]
2025-10-29 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fb8bee-20bf-4eea-9719-045e85f8f181@huawei.com \
--to=shaojijie@huawei.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=cnsztl@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox