From: GOTO Masanori <gotom@debian.or.jp>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>,
GOTO Masanori <gotom@debian.or.jp>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] fix nsp32.c .text.exit error
Date: Fri, 28 Mar 2003 09:18:03 +0900 [thread overview]
Message-ID: <80k7ekgx8k.wl@oris.opensource.jp> (raw)
In-Reply-To: <20030327221410.GE24744@fs.tum.de>
At Thu, 27 Mar 2003 23:14:11 +0100,
Adrian Bunk wrote:
> In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the
> pointer to it isn't __devexit_p resulting in a .text.exit compile error
> if !CONFIG_HOTPLUG.
>
> The following patch is needed:
>
> --- linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c.old 2003-03-27 22:35:04.000000000 +0100
> +++ linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c 2003-03-27 22:36:14.000000000 +0100
> @@ -2125,7 +2125,7 @@
> .name = "nsp32",
> .id_table = nsp32_pci_table,
> .probe = nsp32_probe,
> - .remove = nsp32_remove,
> + .remove = __devexit_p(nsp32_remove),
> #ifdef CONFIG_PM
> /* .suspend = nsp32_suspend,*/
> /* .resume = nsp32_resume,*/
>
>
> This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
> compilation with 2.4.21-pre6.
Looks fine. Thanks!
Regards,
-- gotom
prev parent reply other threads:[~2003-03-28 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-27 22:14 [patch] fix nsp32.c .text.exit error Adrian Bunk
2003-03-28 0:18 ` GOTO Masanori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80k7ekgx8k.wl@oris.opensource.jp \
--to=gotom@debian.or.jp \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox