From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755588AbbFLQV3 (ORCPT ); Fri, 12 Jun 2015 12:21:29 -0400 Received: from mail.eperm.de ([89.247.134.16]:46235 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbbFLQV2 (ORCPT ); Fri, 12 Jun 2015 12:21:28 -0400 From: Stephan Mueller To: Tadeusz Struk Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, keescook@chromium.org, jwboyer@redhat.com, richard@nod.at, steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com, linux-crypto@vger.kernel.org, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com Subject: Re: [PATCH RFC v4 1/4] MPILIB: add mpi_read_buf(), mpi_copy() and mpi_get_size() helpers Date: Fri, 12 Jun 2015 18:21:11 +0200 Message-ID: <8104647.vddsXnptAF@tauon.atsec.com> User-Agent: KMail/4.14.7 (Linux/4.0.4-303.fc22.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20150611190538.31826.97258.stgit@tstruk-mobl1> References: <20150611190533.31826.13956.stgit@tstruk-mobl1> <20150611190538.31826.97258.stgit@tstruk-mobl1> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 11. Juni 2015, 12:05:38 schrieb Tadeusz Struk: Hi Tadeusz, >+ */ >+void *mpi_get_buffer(MPI a, unsigned *nbytes, int *sign) >+{ >+ uint8_t *buf, *p; >+ int n, ret; >+ >+ if (!nbytes) >+ return NULL; >+ >+ n = mpi_get_size(a); Shouldn't n be unsigned int? Ciao Stephan