The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Question about enabling trave_events on module load
Date: Fri, 28 Feb 2020 20:16:54 +0100	[thread overview]
Message-ID: <8107a684-3ade-2457-28e4-c7e29ab1b1f5@intel.com> (raw)

Hello Steven,

I bet that is not the first time said question is asked - that's for 
sure - but I failed to find a method for solving the issue, that is: not 
missing a single trace from the moment given module is loaded. Maybe I'm 
missing something or documentation wasn't clear enough and that's why 
I'm here.

If I am, please point to towards the right direction. Then you can slap 
me for not reading the documentation carefully.

"trace_event=" cmdline option seems to target built-in tracepoints 
_only_ so ain't much of a help to me. After digging the past for some 
time, I've found a very promising thread:
	tracing: Enable tracepoints via module parameters
	https://lore.kernel.org/patchwork/patch/240185/

Sadly, I wasn't able to find _that_ solution (or anything similar for 
that matter) implemented into the kernel.

So far, the only option I came with was separating traces into a 
built-in piece that declares all events upfront so "trace_event=" option 
has something to hook into. Said piece is of course made of a standard 
trace header file filled with macro usage and a .c file with handful of 
EXPORT_TRACEPOINT_SYMBOL(s).

While that solution could suffice, localization is the problem here - if 
a tree my module is built in is configured via -m, the built-in piece 
won't expose symbols at all and 'make' will leave me with bunch of 
"ERROR: <symbol> undefined" for every module my traces were used in. To 
fix the problem, I've relocated my trace .c file to /kernel/trace/. 
Finally it compiles and works as intended..

Not really satisfying, though. While there are some examples of 
subsystems keeping their trace .c in /kernel/trace (e.g.: 
power-traces.c), I don't believe that place is open for _every single 
driver_ to dump their trace sources into.

If indeed traces cannot be enabled on module load, then this is a gap.
While not everyone looked satisfied in the 9year old thread, I believe 
having the gap closed is important - and userspace can always be 
improved upon as time passes.


Thank you in advance for your input and time.

Czarek

             reply	other threads:[~2020-02-28 19:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 19:16 Cezary Rojewski [this message]
2020-03-02  2:17 ` Question about enabling trave_events on module load Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8107a684-3ade-2457-28e4-c7e29ab1b1f5@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox