Re: [PATCH] x86/cpu: Add CPU model numbers for Novalake

[Sohil Mehta <sohil.mehta@intel.com>]

On 8/1/2025 9:00 AM, Tony Luck wrote:

> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
> index 5367dcbf5b30..e345dbdf933e 100644
> --- a/arch/x86/include/asm/intel-family.h
> +++ b/arch/x86/include/asm/intel-family.h
> @@ -152,6 +152,9 @@
>  
>  #define INTEL_WILDCATLAKE_L		IFM(6, 0xD5)
>  
> +#define INTEL_NOVALAKE			IFM(18, 0x01)
> +#define INTEL_NOVALAKE_L		IFM(18, 0x03)
> +

Are we planning to add models from newer families closer to their
predecessors? I like the idea of continuing to group them by type. But,
it would inconvenience folks who are trying to find a name based on a
Family-model number. (I guess that would be a minority.)

Diamond rapids (Family 19) was added at the bottom of the file. Should
that be moved closer to its type?

Also, the /* Family 6 */ comment at the top is now misleading.

Dave had briefly suggested ordering the file based on Family, but I am
not sure if he still feels that way.

https://lore.kernel.org/lkml/40538b12-5929-4f05-b65e-8b807057abd5@intel.com/

>  /* "Small Core" Processors (Atom/E-Core) */
>  
>  #define INTEL_ATOM_BONNELL		IFM(6, 0x1C) /* Diamondville, Pineview */