From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756211AbbJIMyG (ORCPT ); Fri, 9 Oct 2015 08:54:06 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:64247 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756005AbbJIMyD (ORCPT ); Fri, 9 Oct 2015 08:54:03 -0400 From: Arnd Bergmann To: netdev@vger.kernel.org Cc: davem@davemloft.net, Yisen Zhuang , Kenneth Lee , huangdaode , Zhangfei Gao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] net: HNS: fix MDIO dependencies Date: Fri, 09 Oct 2015 14:53:54 +0200 Message-ID: <8114651.XErShuFr2W@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:FHcOq5TXdY2Sq/vm5Zgy/yZnbzEjreC544c+sl/mu5vhrbTCzyE TLSI9li/xm31ecB/L5R7Q0zAEkt9GQEEXHOlyhvzX63HDcTFI8VCSbluGYdVYlQM7fhIPcc 7lIePU+57MqUyNG6b0XOkGexjAjd8F5zZw6KkZDo8kMCE6AFj61dfZbB/vA4VtAZdnYtNbJ z622pKvpzyqSRYofOw+QQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:90JF32xWQRA=:mNvlNTBK9HB2I72EyirnCP hQN2SuOc3JDFMCJLpz6W9nAnkxxj8jz3AZ/O5TqRw2OoPIYb1YfFU49MCsX3VQoWyh64Gnusn /UJeSd5IH8O9JETwVe/H58dsYrbn4PLHVOT72SC92H9b8USHVyevTrxgYlPuA7huqM5BkPhoZ SEX2MS1oSR6p2MzJp9ilckDQF8TQqbwgyHG2M1CaKOI4NqL9thqXY7b36hZkL/MnNVGTjIdiu CINscOskelSYqTjHENUlqshsp+wrkjFSJnLEgpChy0ZSDtKBstXRyJHdkuUZ3R1+wyvGOvL7S zerZozqGaEumE/dFPvG91UL0YqXvICkfYx/GLIdBrbOHCxGLdtFkPgFknby4Yt0JSzV6/V6So lZjfVcMWpkvJ0eBgFbqompGz9ubP75OpsZkNP099exlePj1oAaSm0DNeposBfq1pGs4FAyFYe EaIgMhAnuFZSo1i00UqOJ2Divs+ij9QPCMGalGQMv3WboPgzj6c8BpKVUrCGKA9iqCXDnRwt8 STOi2FeGMiMUKwvccKpAx5BT4pOglZkFBKi3KHZ7pjJgjn98MabAHj/eMEc0hM9jaHl1rUXXs /AWSh6TjXjJswzQgYE8wIpWCx3D3/PbyXqpUcylvcKImbmbtZUB65/tyk1fC6xqfWJwTLO3m9 T7i0g5wNTkTH1Nis+HpaMQGVB0rKUpKvMJV6LEMhHP0n+9oDV/PhF4b0H/9bfw/zgRJBY+ZLW BO7FyxMxX9E6YGpr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced HNS_MDIO Kconfig symbol selects 'MDIO', but that is the wrong symbol as the code used by this driver is provided by PHYLIB rather than the MDIO driver. Also, there is no need to make this driver user selectable, because it is already selected by all drivers that need it. This changes the Kconfig file to select the correct library, and to make the option silent. Signed-off-by: Arnd Bergmann Fixes: 5b904d39406 ("net: add Hisilicon Network Subsystem MDIO support") diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig index 165b5a8aa2ea..8d12b587809e 100644 --- a/drivers/net/ethernet/hisilicon/Kconfig +++ b/drivers/net/ethernet/hisilicon/Kconfig @@ -24,7 +24,6 @@ config HIX5HD2_GMAC config HIP04_ETH tristate "HISILICON P04 Ethernet support" - select PHYLIB select MARVELL_PHY select MFD_SYSCON select HNS_MDIO @@ -33,8 +32,8 @@ config HIP04_ETH want to use the internal ethernet then you should answer Y to this. config HNS_MDIO - tristate "Hisilicon HNS MDIO device Support" - select MDIO + tristate + select PHYLIB ---help--- This selects the HNS MDIO support. It is needed by HNS_DSAF to access the PHY