public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Fraser <nfraser@codeweavers.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Stephane Eranian <eranian@google.com>,
	Tan Xiaojun <tanxiaojun@huawei.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf data: export to JSON
Date: Wed, 31 Mar 2021 06:32:23 -0400	[thread overview]
Message-ID: <8114de32-9874-450e-8d48-8fd4389449fa@codeweavers.com> (raw)
In-Reply-To: <YFs/B0/S7IEKeL/Y@kernel.org>

Hi Arnaldo,

Thanks for the review. I'll send a replacement patch with your suggestions.

On 2021-03-24 9:30 a.m., Arnaldo Carvalho de Melo wrote:
> Do you plan to output the headers too? I think we should, for
> completeness.

I've added the headers, at least the ones that seemed important or easy to
output. The result looks like this:

	"headers": {
			"header-version": 1,
			"captured-on": "2021-03-30T19:24:22Z",
			"data-offset": 304,
			"data-size": 35000,
			"feat-offset": 35304,
			"hostname": "foundry",
			"os-release": "5.11.8-arch1-1",
			"arch": "x86_64",
			"cpu-desc": "Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz",
			"cpuid": "GenuineIntel,6,142,10",
			"nrcpus-online": 8,
			"nrcpus-avail": 8,
			"perf-version": "5.11.gf40ddce88593",
			"cmdline": [
				"/usr/bin/perf",
				"record",
				"vkcube"
			]
	},

(I've thus far avoided outputting anything we don't use; I'm unlikely to design
a useful format for data if I don't have a real use case for it. We will
probably make use of some of the headers though so it's worth doing now.)

Nick

  reply	other threads:[~2021-03-31 10:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 13:06 [PATCH] perf data: export to JSON Nicholas Fraser
2021-03-24 13:30 ` Arnaldo Carvalho de Melo
2021-03-31 10:32   ` Nicholas Fraser [this message]
2021-03-24 18:20 ` Jiri Olsa
2021-03-31 10:38   ` Nicholas Fraser
2021-04-01 12:15     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8114de32-9874-450e-8d48-8fd4389449fa@codeweavers.com \
    --to=nfraser@codeweavers.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tanxiaojun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox