The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: s921975628@gmail.com
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro to replace the repeat pattern
Date: Sat, 25 Dec 2021 22:17:28 +0100 (CET)	[thread overview]
Message-ID: <812386103.202031.1640467048454.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20211225100713.119089-1-s921975628@gmail.com>

----- Ursprüngliche Mail -----
> Von: s921975628@gmail.com
> An: "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, "Miquel Raynal" <miquel.raynal@bootlin.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "RinHizakura"
> <s921975628@gmail.com>
> Gesendet: Samstag, 25. Dezember 2021 11:07:13
> Betreff: [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro to replace the repeat pattern

> From: RinHizakura <s921975628@gmail.com>
> 
> The (ns->regs.column + ns->regs.off) pattern repeats a lot which
> represents the byte shift in next page to access. We can replace it
> with a macro to improve the readability.
> 
> Signed-off-by: RinHizakura <s921975628@gmail.com>
> ---
> drivers/mtd/nand/raw/nandsim.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

      reply	other threads:[~2021-12-25 21:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-25 10:07 [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro to replace the repeat pattern s921975628
2021-12-25 21:17 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=812386103.202031.1640467048454.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=s921975628@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox