public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* modules/ksyms/filenames
@ 2001-07-19 21:54 Peter J. Braam
  2001-07-19 22:36 ` modules/ksyms/filenames Stephen C. Tweedie
  2001-07-20  1:02 ` modules/ksyms/filenames Keith Owens
  0 siblings, 2 replies; 3+ messages in thread
From: Peter J. Braam @ 2001-07-19 21:54 UTC (permalink / raw)
  To: linux-kernel; +Cc: mason, sct

I'm trying to export a symbol (journal_begin/end) from
fs/reiserfs/journal.c. To export the symbols I added to the Makefile:
export-objs := journal.o

There is also a file fs/jbd/journal.c which exports symbols. 

It seems that the two journal.ver files in include/modules/*.ver get
clobbered.

Short of renaming files, is there a good solution for this? 

Thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: modules/ksyms/filenames
  2001-07-19 21:54 modules/ksyms/filenames Peter J. Braam
@ 2001-07-19 22:36 ` Stephen C. Tweedie
  2001-07-20  1:02 ` modules/ksyms/filenames Keith Owens
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen C. Tweedie @ 2001-07-19 22:36 UTC (permalink / raw)
  To: Peter J. Braam; +Cc: linux-kernel, mason, sct

Hi,

On Thu, Jul 19, 2001 at 03:54:00PM -0600, Peter J. Braam wrote:
> I'm trying to export a symbol (journal_begin/end) from
> fs/reiserfs/journal.c. To export the symbols I added to the Makefile:
> export-objs := journal.o
> 
> There is also a file fs/jbd/journal.c which exports symbols. 
> 
> It seems that the two journal.ver files in include/modules/*.ver get
> clobbered.
> 
> Short of renaming files, is there a good solution for this? 

Yes, you can add the EXPORT_SYMBOL to a different source file --- you
don't have to do the export from the same file which defines the
symbol.  linux/kernel/ksyms.c contains exports from all over the rest
of the kernel, for example.  If you pick a reiserfs source file which
already exports symbols and add your exports there, I _think_ it
should work OK.

Cheers,
 Stephen

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: modules/ksyms/filenames
  2001-07-19 21:54 modules/ksyms/filenames Peter J. Braam
  2001-07-19 22:36 ` modules/ksyms/filenames Stephen C. Tweedie
@ 2001-07-20  1:02 ` Keith Owens
  1 sibling, 0 replies; 3+ messages in thread
From: Keith Owens @ 2001-07-20  1:02 UTC (permalink / raw)
  To: Peter J. Braam; +Cc: linux-kernel, mason, sct

On Thu, 19 Jul 2001 15:54:00 -0600, 
"Peter J. Braam" <braam@clusterfs.com> wrote:
>I'm trying to export a symbol (journal_begin/end) from
>fs/reiserfs/journal.c. To export the symbols I added to the Makefile:
>export-objs := journal.o
>
>There is also a file fs/jbd/journal.c which exports symbols. 

It is a "feature" of the module symbol versioning that all objects
which export symbols must have globally unique basenames.  Stupid, I
know, and it will disappear in 2.5.  In the meantime, create
fs/reiserfs/reiserfs_ksyms.c and export the symbols in there.  See
kernel/ksyms.c for an example.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-07-20 10:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-07-19 21:54 modules/ksyms/filenames Peter J. Braam
2001-07-19 22:36 ` modules/ksyms/filenames Stephen C. Tweedie
2001-07-20  1:02 ` modules/ksyms/filenames Keith Owens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox