From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E941A232424 for ; Tue, 14 Jan 2025 15:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866940; cv=none; b=pxtBZc9QrhT1CAqwuIcrlOn33Vvrz3VBwUCYHKi354ETMBPwZ8lULryB6zocQaUmGz5/SITEJKx2sj4UO2n6EtRUOyLrpOeCi6akgR1xmeHP6I/H61DjKEW6ciacq9CnU7fOHLeS44Q2Z9ukJFlESboM2Xu4lnTIZKj5vQ+aC38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866940; c=relaxed/simple; bh=xYkAundS7aywhrA8ujzvdAb/50xm381VeRt1rW0JMbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tXLZxPRdcMrK8vITc3mO+fa+25n3SRvkDD92QfGSh7Nde+3GjyEXuWhmp3X1vFP00L/uFjIM6LD8/kB8wi/l4Tm+S44q7h43Y7iO4rLuS9Me6A/zJJyiZVN5dh58pBbg1GjHjmVL22gN77sjaB5AXvWUVI8krr035g7+B2Jaf8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=RXcmKW1P; arc=none smtp.client-ip=209.85.166.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="RXcmKW1P" Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-3a7d7c1b190so17236855ab.3 for ; Tue, 14 Jan 2025 07:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1736866937; x=1737471737; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A6pc0vLVLOCl99oWfrGPrMAsQjTqC2jWiI5iyztHgH4=; b=RXcmKW1P8vAa8XFu2IjTchgMwrrExwzrW724Z/7OwjSm4zB3i9spLhNJ8bnVXG4Z7R gaDESVPaf7QJRfFC6pVOouY+VTQnZHjZm9SruYHc4JcQuq570L8Q4G/Qad4Qy5+CfcVm BG4LwmFY6CqFFhmPLC9HUr79Z+CtaX+yyGUvftqM+B4SdkHzuMVmMgVSOgnI5DAkUvIY ZMC7NR84dOa3VpuqBmWyenUb+N4s9O2HdN8pcx6rmZPF0rBQ3pY8JUcG3AMcFJjaeMFB B4j0Xw31+dUi0Twe1J7lmPrhn52fLEVBGOGt8bp/fTkWYXDY0uOXjNNUgkurYWRG32GL qSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736866937; x=1737471737; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A6pc0vLVLOCl99oWfrGPrMAsQjTqC2jWiI5iyztHgH4=; b=jYhON86R8LlYmpZ/8jz2VuW9yDFvtZddcjSj4ilcVe9egFrzgKGWICGLJrCfZs/y5A U1uMwWB4V/pV3ksYeXpqjThiu82DUFiL4gP1nqV1VxObTSwZHCt0VKT1q3mBclhbKrYq HJWl2KnttwL/HZCDeP9mvNNkpwl7uWIneoHoziBRFmL5VMPTtp9B6AN/G34if7+GCdNT 2tqwLHI2JpGUcDupmjqgKHYoymp0XDYJkyx39x96aE7Blpwk2LOHkT5y/jTtgp4k8Qn0 DUM9SHFleF8zW3KpXvNXbliEszFZxVWAWJnF7M9QY1zt8UAQhpDbTqIAH5u3p+7vEn3g aOhw== X-Forwarded-Encrypted: i=1; AJvYcCVRhGiaFYf0zvWszCZsZa6IpfndhAsMb/tHkDJzHsGhPPy7mK4HI0EEgAVVHRvedsE8ASjw/Pe9mr0QZ24=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5rvutxWCXq+6oqkwFg6sVI5QW2M3O8qk72CFFCQsn/OopeRwg vZAYk8esW7rVbkVk2CNp8lxTSA5xB3W2K4H6ZQ6Hrv8jS6ohn4GDBD2JT30rniai9P5UJa+At3Y g X-Gm-Gg: ASbGncuC9bdruIk/ZzfuQsuuOiYnsfvY3+0E5YgBN215JkpAoo+05F813EAPXogYSRz GJBaacohtTVhZA7cFT7NKlQ3vC8HFtfffIvNzQfiWppwAJ9dQKS84p3blSflsY7e4a2FckTv6md 6YVokc3d2OGmpO8nYuok2B/khMTZ0uhluf3isipLh1NKYrc0q4MQjTqvjT9o606plUEv2I3ayAC niAe+vqsUYVXAqVF2GPWEBOIYOTq1QGBKOpsEwn0uRY67uSLXxl X-Google-Smtp-Source: AGHT+IGb57wDMTkPiZESOxUOeBWmJs6yV8Cs7lY/DlXIX0vxP6EzoDYWxfogTtZueVLZ8bKUcu+5Cw== X-Received: by 2002:a05:6e02:12ce:b0:3a7:9347:5465 with SMTP id e9e14a558f8ab-3ce3a9a6200mr196772985ab.3.1736866936736; Tue, 14 Jan 2025 07:02:16 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3ce6c1fc60dsm17460395ab.7.2025.01.14.07.02.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 07:02:16 -0800 (PST) Message-ID: <813564af-a67a-4feb-ab32-1ca3bb41edfb@kernel.dk> Date: Tue, 14 Jan 2025 08:02:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] block: no show partitions if partno corrupted To: Edward Adam Davis Cc: hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+fcee6b76cf2e261c51a4@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com References: From: Jens Axboe Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/14/25 7:58 AM, Edward Adam Davis wrote: > diff --git a/block/genhd.c b/block/genhd.c > index 9130e163e191..3a9c36ad6bbd 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -890,6 +890,9 @@ static int show_partition(struct seq_file *seqf, void *v) > > rcu_read_lock(); > xa_for_each(&sgp->part_tbl, idx, part) { > + int partno = bdev_partno(part); > + > + WARN_ON_ONCE(partno >= DISK_MAX_PARTS); > if (!bdev_nr_sectors(part)) > continue; > seq_printf(seqf, "%4d %7d %10llu %pg\n", Surely you still want to continue for that condition? -- Jens Axboe