Re: [PATCH 2/8] cpufreq: imx: Use generic platdev driver

Arnd Bergmann
2016-04-21T09:47:42Z

On Thursday 21 April 2016 14:13:48 Viresh Kumar wrote:
> The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform
> device now, reuse that and remove similar code from platform code.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> arch/arm/mach-imx/imx27-dt.c | 4 ----
> arch/arm/mach-imx/mach-imx51.c | 3 ---
> arch/arm/mach-imx/mach-imx53.c | 2 --
> arch/arm/mach-imx/mach-imx7d.c | 6 ------
> drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> 5 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx27-dt.c b/arch/arm/mach-imx/imx27-dt.c
> index bd42d1bd10af..90c62bf01f9e 100644
> --- a/arch/arm/mach-imx/imx27-dt.c
> +++ b/arch/arm/mach-imx/imx27-dt.c
> @@ -20,11 +20,7 @@
>
> static void __init imx27_dt_init(void)
> {
> - struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> -
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> -
> - platform_device_register_full(&devinfo);
> }
>

Please remove the entire function now, a NULL .init_machine machine
callback pointer has the same effect as the remaining line.

The rest of the patch is fine.

Arnd