Re: [RFC PATCH v3 22/37] irqchip: Add kvx-core-intc core interrupt controller driver

Thomas Gleixner
2024-07-27T13:37:37Z

On Mon, Jul 22 2024 at 11:41, ysionneau@kalrayinc.com wrote:
> +static int __init
> +kvx_init_core_intc(struct device_node *intc, struct device_node *parent)
> +{
> + uint32_t core_nr_irqs;
> + unsigned long cpuid;
> + int ret;
> +
> + ret = kvx_of_parent_cpuid(intc, &cpuid);
> + if (ret)
> + panic("core intc has no CPU parent\n");
> +
> + if (smp_processor_id() != cpuid) {
> + fwnode_dev_initialized(of_fwnode_handle(intc), true);
> + return 0;
> + }
> +
> + if (of_property_read_u32(intc, "kalray,intc-nr-irqs", &core_nr_irqs))
> + core_nr_irqs = KVX_CORE_INTC_IRQ;
> +
> + /* We only have up to 32 interrupts,
> + * linear is likely to be the best choice

Use proper comment style please.

Thanks,

tglx