Re: [RFC PATCH v3 33/37] kvx: Add support for cpuinfo

Yann Sionneau
2024-08-23T13:05:05Z

Hello Krzysztof

On 22/07/2024 14:35, Krzysztof Kozlowski wrote:
> On 22/07/2024 11:41, ysionneau@kalrayinc.com wrote:
>> From: Yann Sionneau <ysionneau@kalrayinc.com>
>>
>> Add support for cpuinfo on kvx arch.
[...]
>> +
>> +static void c_stop(struct seq_file *m, void *v)
>> +{
>> +}
>> +
>> +const struct seq_operations cpuinfo_op = {
> Where is this used?

This is used by `fs/proc/cpuinfo.c`: https://elixir.bootlin.com/linux/v6.10.6/source/fs/proc/cpuinfo.c#L12

I think I should add a #ifdef CONFIG_PROC_FS around this code, or even better use obj-$(CONFIG_PROC_FS) in the Makefile

>
>> + .start = c_start,
>> + .next = c_next,
>> + .stop = c_stop,
>> + .show = show_cpuinfo,
>> +};
>> +

--

Yann