public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Purva Yeshi <purvayeshi550@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] docs: tracing: Reduce maxdepth in index documentation
Date: Fri, 14 Mar 2025 14:25:25 +0530	[thread overview]
Message-ID: <8147edd6-074e-4888-a7a0-798c8d0de612@gmail.com> (raw)
In-Reply-To: <20250312134907.06d27d78@batman.local.home>

On 12/03/25 23:19, Steven Rostedt wrote:
> On Wed, 12 Mar 2025 18:17:17 +0530
> Purva Yeshi <purvayeshi550@gmail.com> wrote:
> 
>> Reduce :maxdepth: from 2 to 1 in index.rst to simplify the table of
>> contents, showing only top-level document titles for better readability.
>>
>> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
>> ---
>>   Documentation/trace/index.rst | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/trace/index.rst b/Documentation/trace/index.rst
>> index 6b268194f..5ddd47ee7 100644
>> --- a/Documentation/trace/index.rst
>> +++ b/Documentation/trace/index.rst
>> @@ -14,7 +14,7 @@ This section provides an overview of Linux tracing mechanisms
>>   and debugging approaches.
>>   
>>   .. toctree::
>> -   :maxdepth: 2
>> +   :maxdepth: 1
> 
> If you made this the first patch, you would only need to modify one place.
> 
> This is a patch series. If the end result is going to be maxdepth 1,
> you shouldn't add a bunch of maxdepth 2 and then in the next patch make
> them all maxdepth 1 as the only change.
> 
> Just change the one maxdepth 1 first, and then you can update the code
> with the new maxdepth of 1.
> 
> -- Steve

Hi Steven,

Got it. If I understand correctly, you’re suggesting that I reorder the 
patches so that the 'maxdepth' change happens first. That way, I won’t 
introduce maxdepth: 2 only to change it in the next patch. Does that 
sound right?

> 
> 
>>   
>>      debugging
>>      tracepoints
>> @@ -28,7 +28,7 @@ The following are the primary tracing frameworks integrated into
>>   the Linux kernel.
>>   
>>   .. toctree::
>> -   :maxdepth: 2
>> +   :maxdepth: 1
>>   
>>      ftrace
>>      ftrace-design
>> @@ -47,7 +47,7 @@ A detailed explanation of event tracing mechanisms and their
>>   applications.
>>   
>>   .. toctree::
>> -   :maxdepth: 2
>> +   :maxdepth: 1
>>   
>>      events
>>      events-kmem
>> @@ -65,7 +65,7 @@ This section covers tracing features that monitor hardware
>>   interactions and system performance.
>>   
>>   .. toctree::
>> -   :maxdepth: 2
>> +   :maxdepth: 1
>>   
>>      intel_th
>>      stm
>> @@ -85,7 +85,7 @@ These tools allow tracing user-space applications and
>>   interactions.
>>   
>>   .. toctree::
>> -   :maxdepth: 2
>> +   :maxdepth: 1
>>   
>>      user_events
>>   
> 


  parent reply	other threads:[~2025-03-14  8:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 12:47 [PATCH v3 2/2] docs: tracing: Reduce maxdepth in index documentation Purva Yeshi
2025-03-12 17:49 ` Steven Rostedt
2025-03-13  3:02   ` Bagas Sanjaya
2025-03-13 11:04     ` Steven Rostedt
2025-03-13 12:16       ` Bagas Sanjaya
2025-03-14  8:56         ` Purva Yeshi
2025-03-14 12:41           ` Steven Rostedt
2025-03-18 11:35             ` Purva Yeshi
2025-03-14  8:55   ` Purva Yeshi [this message]
2025-03-14 12:35     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8147edd6-074e-4888-a7a0-798c8d0de612@gmail.com \
    --to=purvayeshi550@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox