From: Adrian Hunter <adrian.hunter@intel.com>
To: Nitin Yadav <n-yadav@ti.com>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci_am654: fix start loop index for TAP value parsing
Date: Thu, 26 Oct 2023 10:03:49 +0300 [thread overview]
Message-ID: <8148dae9-e3fc-4589-ba57-a3f7a3e63b80@intel.com> (raw)
In-Reply-To: <8b7f948d-316c-4135-875a-de455ff4849c@intel.com>
On 26/10/23 10:00, Adrian Hunter wrote:
> On 26/10/23 09:14, Nitin Yadav wrote:
>> ti,otap-del-sel-legacy/ti,itap-del-sel-legacy passed from DT
>> are currently ignored for all SD/MMC and eMMC modes. Fix this
>> by making start loop index to MMC_TIMING_LEGACY.
>>
>> Fixes: 8ee5fc0e0b3be ("mmc: sdhci_am654: Update OTAPDLY writes")
>>
>
> There isn't usually a blank line here
>
> Perhaps a Cc: stable@vger.kernel.org tag?
>
>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
>
> Nevertheless:
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Sorry, sent that prematurely - see comment below
>
>
>> ---
>> drivers/mmc/host/sdhci_am654.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 544aaaf5cb0f..aae9d255c6a1 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -606,7 +606,7 @@ static int sdhci_am654_get_otap_delay(struct sdhci_host *host,
>> return 0;
>> }
>>
Isn't the MMC_TIMING_LEGACY information read at the top of
sdhci_am654_get_otap_delay()?
>> - for (i = MMC_TIMING_MMC_HS; i <= MMC_TIMING_MMC_HS400; i++) {
>> + for (i = MMC_TIMING_LEGACY; i <= MMC_TIMING_MMC_HS400; i++) {
>>
>> ret = device_property_read_u32(dev, td[i].otap_binding,
>> &sdhci_am654->otap_del_sel[i]);
>
next prev parent reply other threads:[~2023-10-26 7:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 6:14 [PATCH] mmc: sdhci_am654: fix start loop index for TAP value parsing Nitin Yadav
2023-10-26 7:00 ` Adrian Hunter
2023-10-26 7:03 ` Adrian Hunter [this message]
2023-10-27 6:11 ` Nitin Yadav
2023-10-30 8:07 ` Vignesh Raghavendra
2023-11-03 11:16 ` Ulf Hansson
2023-11-03 11:16 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8148dae9-e3fc-4589-ba57-a3f7a3e63b80@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=n-yadav@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox