Fw: Re: Elitegroup K7S5A + usb_storage problem

Fw: Re: Elitegroup K7S5A + usb_storage problem

[Pete Zaitcev]

On Sat, 6 Aug 2005 11:49:05 -0400 (EDT), Alan Stern <stern@rowland.harvard.edu> wrote:

> When asked what went wrong, the device says it didn't understand the 
> INQUIRY command.  This is a fatal error; if a device can't identify itself 
> there's no way for Linux to use it.
> 
> In short, your mp3stick is worthless.  Trade it in for one that works.

This is only true if usb-storage is used. The stick may work with ub.

Martin, please apply the attached patch and enable CONFIG_BLK_DEV_UB.
If you do not run a userland with udev, do this:

mknod /dev/uba b 180 0
mknod /dev/uba1 b 180 1

Let me know how it went.

-- Pete

diff -urp -X dontdiff linux-2.6.12/drivers/usb/storage/usb.c linux-2.6.12-lem/drivers/usb/storage/usb.c
--- linux-2.6.12/drivers/usb/storage/usb.c	2005-06-17 12:48:29.000000000 -0700
+++ linux-2.6.12-lem/drivers/usb/storage/usb.c	2005-07-25 22:12:53.000000000 -0700
@@ -150,7 +150,9 @@ static struct usb_device_id storage_usb_
 	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_QIC, US_PR_BULK) },
 	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_UFI, US_PR_BULK) },
 	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_8070, US_PR_BULK) },
+#if !defined(CONFIG_BLK_DEV_UB) && !defined(CONFIG_BLK_DEV_UB_MODULE)
 	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_SCSI, US_PR_BULK) },
+#endif
 
 	/* Terminating entry */
 	{ }
@@ -224,8 +226,10 @@ static struct us_unusual_dev us_unusual_
 	  .useTransport = US_PR_BULK},
 	{ .useProtocol = US_SC_8070,
 	  .useTransport = US_PR_BULK},
+#if !defined(CONFIG_BLK_DEV_UB) && !defined(CONFIG_BLK_DEV_UB_MODULE)
 	{ .useProtocol = US_SC_SCSI,
 	  .useTransport = US_PR_BULK},
+#endif
 
 	/* Terminating entry */
 	{ NULL }

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Martin Maurer]

[-- Attachment #1.1: Type: text/plain, Size: 2825 bytes --]

Hi Pete,

when using ub with your patch i get a lot further:
the device is detected and uba+uba1 entries appear.
I can mount the device correctly.
Copying the files down and comparing them with the originals gives correct 
results.

but:
when i delete the files which are on the stick and do an umount/mount cycle, 
the files are there again. 
Copying files to the stick gives wrong results too.
Once the created file vanished after the remount,
and once it was there with a different name/size/date and garbage as content.

I didnt try ub without your patch (CONFIG_BLK_DEV_UB was disabled in my kernel 
configuration). Shall I try this too?

greetings
Martin


On Saturday, 6. August 2005 22:02, Pete Zaitcev wrote:
> On Sat, 6 Aug 2005 11:49:05 -0400 (EDT), Alan Stern 
<stern@rowland.harvard.edu> wrote:
> > When asked what went wrong, the device says it didn't understand the
> > INQUIRY command.  This is a fatal error; if a device can't identify
> > itself there's no way for Linux to use it.
> >
> > In short, your mp3stick is worthless.  Trade it in for one that works.
>
> This is only true if usb-storage is used. The stick may work with ub.
>
> Martin, please apply the attached patch and enable CONFIG_BLK_DEV_UB.
> If you do not run a userland with udev, do this:
>
> mknod /dev/uba b 180 0
> mknod /dev/uba1 b 180 1
>
> Let me know how it went.
>
> -- Pete
>
> diff -urp -X dontdiff linux-2.6.12/drivers/usb/storage/usb.c
> linux-2.6.12-lem/drivers/usb/storage/usb.c ---
> linux-2.6.12/drivers/usb/storage/usb.c	2005-06-17 12:48:29.000000000 -0700
> +++ linux-2.6.12-lem/drivers/usb/storage/usb.c	2005-07-25
> 22:12:53.000000000 -0700 @@ -150,7 +150,9 @@ static struct usb_device_id
> storage_usb_
>  	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_QIC, US_PR_BULK) },
>  	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_UFI, US_PR_BULK) },
>  	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_8070, US_PR_BULK) },
> +#if !defined(CONFIG_BLK_DEV_UB) && !defined(CONFIG_BLK_DEV_UB_MODULE)
>  	{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, US_SC_SCSI, US_PR_BULK) },
> +#endif
>
>  	/* Terminating entry */
>  	{ }
> @@ -224,8 +226,10 @@ static struct us_unusual_dev us_unusual_
>  	  .useTransport = US_PR_BULK},
>  	{ .useProtocol = US_SC_8070,
>  	  .useTransport = US_PR_BULK},
> +#if !defined(CONFIG_BLK_DEV_UB) && !defined(CONFIG_BLK_DEV_UB_MODULE)
>  	{ .useProtocol = US_SC_SCSI,
>  	  .useTransport = US_PR_BULK},
> +#endif
>
>  	/* Terminating entry */
>  	{ NULL }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[-- Attachment #1.2: mp3stick_working.dmesg --]
[-- Type: text/plain, Size: 669 bytes --]

hub 1-1:1.0: state 5 ports 4 chg 0000 evt 0010
hub 1-1:1.0: port 4, status 0101, change 0001, 12 Mb/s
hub 1-1:1.0: debounce: port 4: total 100ms stable 100ms status 0x101
usb 1-1.4: new full speed USB device using ohci_hcd and address 7
usb 1-1.4: ep0 maxpacket = 32
usb 1-1.4: new device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1.4: hotplug
usb 1-1.4: adding 1-1.4:1.0 (config #1, interface 0)
usb 1-1.4:1.0: hotplug
ub 1-1.4:1.0: usb_probe_interface
ub 1-1.4:1.0: usb_probe_interface - got id
ub(1.7): GetMaxLUN returned 0 bytes
ub(1.7): GetMaxLUN returned 0 bytes
ub(1.7): GetMaxLUN returned 0 bytes
 uba: uba1
hub 1-1:1.0: state 5 ports 4 chg 0000 evt 0010

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Pete Zaitcev]

On Sun, 7 Aug 2005 02:22:53 +0200, Martin Maurer <martinmaurer@gmx.at> wrote:

> when i delete the files which are on the stick and do an umount/mount
> cycle, the files are there again. 
> Copying files to the stick gives wrong results too.

Curious. First of all, I have a request: do not call this device a "stick".
It is terribly misleading word with which to call a fully-featured MP3
player. DNT uses it in a specific context, as a product name.

I'd like to have a usbmon trace of a session, from plugging, through
copying, through unplugging. Do not send it to the whole cc: list.
Do you need instructions?

-- Pete

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Alan Stern]

On Sun, 7 Aug 2005, Martin Maurer wrote:

> Hi Pete,
> 
> when using ub with your patch i get a lot further:
> the device is detected and uba+uba1 entries appear.
> I can mount the device correctly.
> Copying the files down and comparing them with the originals gives correct 
> results.
> 
> but:
> when i delete the files which are on the stick and do an umount/mount cycle, 
> the files are there again. 
> Copying files to the stick gives wrong results too.
> Once the created file vanished after the remount,
> and once it was there with a different name/size/date and garbage as content.

It sounds as though the device isn't actually carrying out the write 
operations.  Is it write-protected?

Alan Stern

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[martin.maurer]

Hi Alan,

no. the stick doesn't have a write protection switch.
Once when i tried to copy a file to the mp3 player i got a new file there on remount,
but it consisted of incorrect data. (so writing seemed to be possible and just went wrong)
(in that case the fat seemed to be damaged after i had tried this, so that windows wasn't 
able to read it correctly any more.
(formatting from the mp3 players menu helped)

greetings
Martin

PS: just as an info - i sent a usbmon trace to Pete Zaitcev today, should I send it to you too? 

Alan Stern <stern@rowland.harvard.edu> schrieb am 07.08.05 17:14:52:
On Sun, 7 Aug 2005, Martin Maurer wrote:

> Hi Pete,
> 
> when using ub with your patch i get a lot further:
> the device is detected and uba+uba1 entries appear.
> I can mount the device correctly.
> Copying the files down and comparing them with the originals gives correct 
> results.
> 
> but:
> when i delete the files which are on the stick and do an umount/mount cycle, 
> the files are there again. 
> Copying files to the stick gives wrong results too.
> Once the created file vanished after the remount,
> and once it was there with a different name/size/date and garbage as content.

It sounds as though the device isn't actually carrying out the write 
operations.  Is it write-protected?

Alan Stern

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Alan Stern]

On Sun, 7 Aug 2005 martin.maurer@email.de wrote:

> Hi Alan,
> 
> no. the stick doesn't have a write protection switch.
> Once when i tried to copy a file to the mp3 player i got a new file there on remount,
> but it consisted of incorrect data. (so writing seemed to be possible and just went wrong)
> (in that case the fat seemed to be damaged after i had tried this, so that windows wasn't 
> able to read it correctly any more.
> (formatting from the mp3 players menu helped)

Well, perhaps the device isn't consistently writing data to the 
correct locations.

> greetings
> Martin
> 
> PS: just as an info - i sent a usbmon trace to Pete Zaitcev today, should I send it to you too? 

Pete is quite as competent at solving this kind of problem as I am.  And
he knows the ub driver much better, so I'm happy to bow out and let him
worry about it!  :-)

Just out of curiosity, if you plug the player into a Windows system 
without installing any special drivers first, will Windows be able to read 
and write files okay?  If it can, a USB packet trace may give Pete a clue 
as to where to look.

Alan Stern

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Martin Maurer]

[-- Attachment #1: Type: text/plain, Size: 1684 bytes --]

On Sunday, 7. August 2005 20:08, Alan Stern wrote:
> On Sun, 7 Aug 2005 martin.maurer@email.de wrote:
> > Hi Alan,
> >
> > no. the stick doesn't have a write protection switch.
> > Once when i tried to copy a file to the mp3 player i got a new file there
> > on remount, but it consisted of incorrect data. (so writing seemed to be
> > possible and just went wrong) (in that case the fat seemed to be damaged
> > after i had tried this, so that windows wasn't able to read it correctly
> > any more.
> > (formatting from the mp3 players menu helped)
>
> Well, perhaps the device isn't consistently writing data to the
> correct locations.
>
> > greetings
> > Martin
> >
> > PS: just as an info - i sent a usbmon trace to Pete Zaitcev today, should
> > I send it to you too?
>
> Pete is quite as competent at solving this kind of problem as I am.  And
> he knows the ub driver much better, so I'm happy to bow out and let him
> worry about it!  :-)
>
> Just out of curiosity, if you plug the player into a Windows system
> without installing any special drivers first, will Windows be able to read
> and write files okay?  If it can, a USB packet trace may give Pete a clue
> as to where to look.
as far as i recall i didnt install any special drivers for my win 2k and win 
xp systems. (i got this mp3 player quite a while now...)
How would I do such an packet trace ?


>
> Alan Stern
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

[Pete Zaitcev]

On Sun, 7 Aug 2005 22:47:40 +0200, Martin Maurer <martinmaurer@gmx.at> wrote:

> > Just out of curiosity, if you plug the player into a Windows system
> > without installing any special drivers first, will Windows be able to read
> > and write files okay?  If it can, a USB packet trace may give Pete a clue
> > as to where to look.

> as far as i recall i didnt install any special drivers for my win 2k and win 
> xp systems. (i got this mp3 player quite a while now...)
> How would I do such an packet trace ?

I have never run Snoopy on Windows myself and I did not want to subject
you to it. Let's try my delay patch first. If that fails, I guess we
have to get instructions from someone who knows how to run Snoopy.
Maybe Windows issues some cache synchronization command when it
commits FAT. Then the packet trace should show it.

-- Pete