* [PATCH] drm/mediatek: add ARM_SMCCC dependency
@ 2016-06-27 9:22 Arnd Bergmann
2016-06-27 9:30 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-06-27 9:22 UTC (permalink / raw)
To: David Airlie, Philipp Zabel
Cc: Arnd Bergmann, Matthias Brugger, CK Hu, Jie Qiu, dri-devel,
linux-kernel, linux-arm-kernel, linux-mediatek
ARM SMCCC is only set for ARMv7 and ARMv8 CPUs, but we currently
allow the driver to be build for older architecture levels as
well, which results in a link failure:
drivers/gpu/built-in.o: In function `mtk_hdmi_hw_make_reg_writable':
:(.text+0x1e737c): undefined reference to `arm_smccc_smc'
This adds a Kconfig dependency. The patch applies on my two
previous fixes that are not yet applied, so please apply all
three to get randconfig builds to work correctly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
---
drivers/gpu/drm/mediatek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 96ebf8bb6024..294de4549922 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -3,6 +3,7 @@ config DRM_MEDIATEK
depends on DRM
depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
depends on COMMON_CLK
+ depends on HAVE_ARM_SMCCC
depends on OF
select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mediatek: add ARM_SMCCC dependency
2016-06-27 9:22 [PATCH] drm/mediatek: add ARM_SMCCC dependency Arnd Bergmann
@ 2016-06-27 9:30 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2016-06-27 9:30 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie, Philipp Zabel
Cc: CK Hu, Jie Qiu, dri-devel, linux-kernel, linux-arm-kernel,
linux-mediatek
On 06/27/2016 11:22 AM, Arnd Bergmann wrote:
> ARM SMCCC is only set for ARMv7 and ARMv8 CPUs, but we currently
> allow the driver to be build for older architecture levels as
> well, which results in a link failure:
>
> drivers/gpu/built-in.o: In function `mtk_hdmi_hw_make_reg_writable':
> :(.text+0x1e737c): undefined reference to `arm_smccc_smc'
>
> This adds a Kconfig dependency. The patch applies on my two
> previous fixes that are not yet applied, so please apply all
> three to get randconfig builds to work correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 96ebf8bb6024..294de4549922 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -3,6 +3,7 @@ config DRM_MEDIATEK
> depends on DRM
> depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
> depends on COMMON_CLK
> + depends on HAVE_ARM_SMCCC
> depends on OF
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-27 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-27 9:22 [PATCH] drm/mediatek: add ARM_SMCCC dependency Arnd Bergmann
2016-06-27 9:30 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox