From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbcF0JbB (ORCPT ); Mon, 27 Jun 2016 05:31:01 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33785 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbcF0Ja6 (ORCPT ); Mon, 27 Jun 2016 05:30:58 -0400 Subject: Re: [PATCH] drm/mediatek: add ARM_SMCCC dependency To: Arnd Bergmann , David Airlie , Philipp Zabel References: <20160627092416.1463857-1-arnd@arndb.de> Cc: CK Hu , Jie Qiu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org From: Matthias Brugger Message-ID: <8177d497-69bb-db97-5dec-98417dad012a@gmail.com> Date: Mon, 27 Jun 2016 11:30:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160627092416.1463857-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2016 11:22 AM, Arnd Bergmann wrote: > ARM SMCCC is only set for ARMv7 and ARMv8 CPUs, but we currently > allow the driver to be build for older architecture levels as > well, which results in a link failure: > > drivers/gpu/built-in.o: In function `mtk_hdmi_hw_make_reg_writable': > :(.text+0x1e737c): undefined reference to `arm_smccc_smc' > > This adds a Kconfig dependency. The patch applies on my two > previous fixes that are not yet applied, so please apply all > three to get randconfig builds to work correctly. > > Signed-off-by: Arnd Bergmann > Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") > --- > drivers/gpu/drm/mediatek/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Matthias Brugger > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 96ebf8bb6024..294de4549922 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -3,6 +3,7 @@ config DRM_MEDIATEK > depends on DRM > depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) > depends on COMMON_CLK > + depends on HAVE_ARM_SMCCC > depends on OF > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER >