From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751451AbdLPG1w (ORCPT <rfc822;w@1wt.eu>);
        Sat, 16 Dec 2017 01:27:52 -0500
Received: from mout.web.de ([212.227.17.11]:58717 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750730AbdLPG1u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 16 Dec 2017 01:27:50 -0500
Subject: Re: jsm_tty: Deletion of a null pointer check in two functions?
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>,
        linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>, Jiri Slaby <jslaby@suse.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net>
 <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com>
 <1511977896.19952.69.camel@perches.com> <20171129180528.GA24705@kroah.com>
 <089a4b85-64e8-cb4a-c5f8-9abb2556e5e5@users.sourceforge.net>
 <8ae240fa-7f77-8f4c-225c-853cdda73a67@linux.vnet.ibm.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <817fcf72-cd9d-bf5b-ce83-ce2844e3e901@users.sourceforge.net>
Date: Sat, 16 Dec 2017 07:27:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <8ae240fa-7f77-8f4c-225c-853cdda73a67@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:XckONPb6mzLRrxY6y5faVOSeTD9gp9XM8UA/MjQpl1AC5JwXzzM
 01EqrO0eW2Rf5NNoJ5Rr4+DiOfO0XCJyMWch7WztyLnACd/U+5p3Le3Rz7uTi5UCKZyp0YH
 lLzaxiJfuedpD6UczL5/xuTojsQjDQmNWTEeiyFTBkocC/wbbywFzt7Vu/SfKLyjxPBZrND
 yK4MYGB9llzLV1XwoKWyA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wJuyTemRvkY=:JBX7EJRWOKhMQD9raw8sx2
 lMbVywFykA8BZa55kMkLdWQA1qrnnwa9VwDsnQmMWB7d2Itg/psS+B/jiOuksZqY4vRM9RaDV
 oXQqzexw0jo4aSxMrQDHIt/JKytRF3MNjsxCpmU26P55t7hLGkPbPPX/fZdsYcVn3aFZWt1bc
 nmgLMhjz46eOjU+aEcioJ0jrIgITNRaUkqZAzuWI7Izt8WjP1v2Zq1d56gj7eaaLBbS8iVY4t
 Mwj5Yl5LcnFgoa+8QZbuQtrrxY8uuAz2GcL9SV1MouDDsXaOqpX/D4ax2/45csY62mXJjqSyC
 p2FEyuCgsKDp811UyWbEI6+6APP6YZFdnNm+5fwXhlZwBSjado5Ll83hzK6bKcRAog8NYjItB
 RdticKeEzpHPL1KEluzW0/2VEAxUL6XIY46db/cI1FduOahJ0AtMuyjvInLQXYCilMpmDShq8
 iN+RMwkEXzqcYALIenabaeV9qbd7gvyjDzY/BnLTdeKP2U9CTmLpm1offfANGne62PAXmAV3Y
 mYoVRKl+TJzD6PJAyB/pvApGfrTu9nPRT7PnY4oMafHJ24/C66xChmSD92z5KzhQzuqGe+on7
 bvOeIgz3ayLxSRxeKOXlZa4RFweAKS4zavfXhsIle/eHPm9eevuhyD9JKaM4hHHXHj3YaMWE8
 LTQlpvg7qVg1vb4VzqUzPFg0Vu7OQJX9CtkYQNCNMgRyxQbI55b1WfnFRCsqAe21lpAs6SJ19
 NCqbzqdAf/ztMJaB4yntX6iW+svVKeuP42JIc6V8kC38KYDsoJZKxQmA82HCSBu39ZBfvHC2c
 J/oUsRgSBl1V6T5FKlQIZ9M3QbDKf6jZ0oE6GTZOhwm1DIhV4w=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Thanks for the fix.

Thanks for your positive feedback.


> I was on vacation - but now seeing all the analysis made here,

I assume that special communication settings could trigger
corresponding consequences for the discussed source code adjustment.


> if "ch" can't be NULL then please go ahead and remove the check =)

Would you dare to convert this request into a concrete patch?

Regards,
Markus